Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2554723002: Fix Data Saver settings preference crash on Lenovo Zuk devices (Closed)

Created:
4 years ago by megjablon
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Data Saver settings preference crash on Lenovo Zuk devices The Data Saver settings menu is crashing for Lenovo Zuk devices due to findViewById returning null. Since we don't use the title in the PreferenceCategory, make the DataReductionStatsPreference a Preference and set the widget layout resource dynamically. Also, set the preference to not be selectable so that it does not have dividers and cannot be clicked. BUG=666412 Committed: https://crrev.com/c8b5b01012a5b4245eddb891c2557e7c6e3e64b6 Cr-Commit-Position: refs/heads/master@{#436686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/android/java/res/xml/data_reduction_preferences.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java View 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
megjablon
PTAL, thanks!
4 years ago (2016-12-06 03:07:59 UTC) #3
David Trainor- moved to gerrit
lgtm thanks!
4 years ago (2016-12-06 18:23:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554723002/1
4 years ago (2016-12-06 18:48:00 UTC) #7
tbansal1
lgtm
4 years ago (2016-12-06 19:03:01 UTC) #8
tbansal1
Thanks for fixing this.
4 years ago (2016-12-06 19:03:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 19:34:02 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 19:37:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8b5b01012a5b4245eddb891c2557e7c6e3e64b6
Cr-Commit-Position: refs/heads/master@{#436686}

Powered by Google App Engine
This is Rietveld 408576698