Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2552093003: [chromedriver] Replace "--load-component-extension" with "--disable-extensions-except" switch.

Created:
4 years ago by gmanikpure
Modified:
4 years ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Replace "--load-component-extension" with "--disable-extensions-except" switch. BUG=chromedriver:1625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
gmanikpure
4 years ago (2016-12-06 18:43:20 UTC) #2
gmanikpure
On 2016/12/06 18:43:20, gmanikpure wrote: Hi Sam, On Linux, Java & Py tests runs successfully ...
4 years ago (2016-12-06 18:48:13 UTC) #3
samuong
I don't think this will work in the general case. We don't *always* want to ...
4 years ago (2016-12-06 19:00:52 UTC) #4
gmanikpure
4 years ago (2016-12-06 19:04:38 UTC) #5
On 2016/12/06 19:00:52, samuong wrote:
> I don't think this will work in the general case. We don't *always* want to
> disable extensions, so we can't unconditionally use
--disable-extensions-except.
> And if we use --load-extension, we run into the "disable developer mode
> extensions" dialog that --load-component-extension is supposed to work around.
> 
> I've got a design proposal that should fix this over at
>
https://docs.google.com/document/d/1JYj9K61UyxIYavR8_HATYIglR9T_rDwAtLLsD3fbD...
> (Googlers-only, sorry). In the meantime, can we disable the failing tests?

Sure, Thanks Sam. I have uploaded https://codereview.chromium.org/2550093004/
for disabling the tests.

Powered by Google App Engine
This is Rietveld 408576698