Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2551973004: client/isolate: add context to NewChecker func (Closed)

Created:
4 years ago by djd-OOO-Apr2017
Modified:
4 years ago
Reviewers:
mcgreevy
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

client/isolate: add context to NewChecker func This make Checker consistent with Uploader, and allows the underyling context to be cancelled if the isolate process ends early. Also removes some punctuation from a test case that was upsetting vet. BUG=598990 R=mcgreevy@chromium.org Committed: https://github.com/luci/luci-go/commit/8336655396a49a699ff3f7d9abf469ad7b8dd2eb

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M client/cmd/isolate/checker.go View 1 3 chunks +6 lines, -4 lines 0 comments Download
M client/cmd/isolate/checker_test.go View 1 3 chunks +4 lines, -4 lines 0 comments Download
M client/cmd/isolate/exp_archive.go View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
djd-OOO-Apr2017
4 years ago (2016-12-07 05:13:59 UTC) #1
mcgreevy
lgtm
4 years ago (2016-12-07 05:19:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551973004/20001
4 years ago (2016-12-07 05:31:08 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-07 05:36:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/8336655396a49a699ff3f7d9abf469ad7b8dd2eb

Powered by Google App Engine
This is Rietveld 408576698