Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: client/cmd/isolate/exp_archive.go

Issue 2551973004: client/isolate: add context to NewChecker func (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/cmd/isolate/checker_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/exp_archive.go
diff --git a/client/cmd/isolate/exp_archive.go b/client/cmd/isolate/exp_archive.go
index 8054cc7b483df302d1587a3ae63d65521f1d7337..fe93609e38809c18efee1974d41263f3b96c0b3d 100644
--- a/client/cmd/isolate/exp_archive.go
+++ b/client/cmd/isolate/exp_archive.go
@@ -95,8 +95,7 @@ func (c *expArchiveRun) main() error {
// Set up a checker and pair of uploaders. One uploader is for in-memory
// files, and one is for on-disk files (we want to limit the latter to only
// one upload at a time).
- // TODO(djd): Make NewChecker take a context arg.
- checker := NewChecker(client)
+ checker := NewChecker(ctx, client)
memUploader, fileUploader := NewUploader(ctx, client, 10), NewUploader(ctx, client, 1)
// Walk each of the deps, partioning the results into symlinks and files categorised by size.
« no previous file with comments | « client/cmd/isolate/checker_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698