Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2551963004: Add material-foundation dependencies. (Closed)

Created:
4 years ago by lpromero
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add material-foundation dependencies. These are third party libraries used by Chrome for iOS. BUG=none Committed: https://crrev.com/ad2439999bcdedbea7b41ae6dbff81221eb0df7e Cr-Commit-Position: refs/heads/master@{#438189}

Patch Set 1 #

Patch Set 2 : BUILD files #

Patch Set 3 : Fix path to repos #

Patch Set 4 : Don't treat as Chromium code #

Total comments: 2

Patch Set 5 : Add Revision in README.chromium files #

Total comments: 2

Patch Set 6 : Add MDFTextAccessibility URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -2 lines) Patch
M .gitignore View 1 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A ios/third_party/material_font_disk_loader_ios/BUILD.gn View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A ios/third_party/material_font_disk_loader_ios/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/third_party/material_font_disk_loader_ios/README.chromium View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A ios/third_party/material_roboto_font_loader_ios/BUILD.gn View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A ios/third_party/material_roboto_font_loader_ios/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/third_party/material_roboto_font_loader_ios/README.chromium View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A ios/third_party/material_sprited_animation_view_ios/BUILD.gn View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A ios/third_party/material_sprited_animation_view_ios/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/third_party/material_sprited_animation_view_ios/README.chromium View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M ios/third_party/material_text_accessibility_ios/BUILD.gn View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ios/third_party/material_text_accessibility_ios/README.chromium View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
lpromero
4 years ago (2016-12-07 18:59:34 UTC) #1
lpromero
4 years ago (2016-12-07 18:59:53 UTC) #3
rohitrao (ping after 24h)
https://codereview.chromium.org/2551963004/diff/60001/ios/third_party/material_font_disk_loader_ios/README.chromium File ios/third_party/material_font_disk_loader_ios/README.chromium (right): https://codereview.chromium.org/2551963004/diff/60001/ios/third_party/material_font_disk_loader_ios/README.chromium#newcode3 ios/third_party/material_font_disk_loader_ios/README.chromium:3: License: Apache 2.0 Can we add Version: 0 Revision: ...
4 years ago (2016-12-13 13:22:16 UTC) #8
lpromero
https://codereview.chromium.org/2551963004/diff/60001/ios/third_party/material_font_disk_loader_ios/README.chromium File ios/third_party/material_font_disk_loader_ios/README.chromium (right): https://codereview.chromium.org/2551963004/diff/60001/ios/third_party/material_font_disk_loader_ios/README.chromium#newcode3 ios/third_party/material_font_disk_loader_ios/README.chromium:3: License: Apache 2.0 On 2016/12/13 13:22:16, rohitrao wrote: > ...
4 years ago (2016-12-13 14:20:32 UTC) #9
rohitrao (ping after 24h)
lgtm I've verified that these changes have: chrome-eng-review approval security approval opensource-licensing approval https://codereview.chromium.org/2551963004/diff/80001/ios/third_party/material_text_accessibility_ios/README.chromium File ...
4 years ago (2016-12-13 14:22:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551963004/100001
4 years ago (2016-12-13 15:33:08 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-13 16:40:27 UTC) #16
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ad2439999bcdedbea7b41ae6dbff81221eb0df7e Cr-Commit-Position: refs/heads/master@{#438189}
4 years ago (2016-12-13 16:42:17 UTC) #18
lpromero
4 years ago (2016-12-13 21:43:56 UTC) #19
Message was sent while issue was closed.
Was addressed before submitting.

https://codereview.chromium.org/2551963004/diff/80001/ios/third_party/materia...
File ios/third_party/material_text_accessibility_ios/README.chromium (right):

https://codereview.chromium.org/2551963004/diff/80001/ios/third_party/materia...
ios/third_party/material_text_accessibility_ios/README.chromium:2: URL: None
On 2016/12/13 14:22:23, rohitrao wrote:
> Does this library have a URL?

Done.

Powered by Google App Engine
This is Rietveld 408576698