Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2551803002: FontResource: introduce some CHECKs for setRevalidatingRequest (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FontResource: introduce some CHECKs for setRevalidatingRequest To confirm if timers were stopped correctly always when we are revalidating the resource, add some CHECKs. Once we confirm that this is implemented correctly, change CHECKs to DCHECKs. BUG=670638 Committed: https://crrev.com/773c66c551f143e25ff6993e8af3377358592d52 Cr-Commit-Position: refs/heads/master@{#436536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/resource/FontResource.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Takashi Toyoshima
I think this works fine now, but I'd have some additional checks here just in ...
4 years ago (2016-12-05 08:21:43 UTC) #5
Kunihiko Sakamoto
lgtm
4 years ago (2016-12-05 08:38:48 UTC) #6
yhirano
lgtm
4 years ago (2016-12-05 09:04:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551803002/1
4 years ago (2016-12-06 05:14:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 05:19:09 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-06 05:23:00 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/773c66c551f143e25ff6993e8af3377358592d52
Cr-Commit-Position: refs/heads/master@{#436536}

Powered by Google App Engine
This is Rietveld 408576698