Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: third_party/WebKit/Source/core/loader/resource/FontResource.cpp

Issue 2551803002: FontResource: introduce some CHECKs for setRevalidatingRequest (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/resource/FontResource.cpp
diff --git a/third_party/WebKit/Source/core/loader/resource/FontResource.cpp b/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
index 15569e199bf50ed0dd9f3facdeacd3be32f4e5bc..36a6efd35f116893e7e928f93b9fa2a9b20bfb41 100644
--- a/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
+++ b/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
@@ -105,6 +105,11 @@ void FontResource::didAddClient(ResourceClient* c) {
void FontResource::setRevalidatingRequest(const ResourceRequest& request) {
// Reload will use the same object, and needs to reset |m_loadLimitState|
// before any didAddClient() is called again.
+ // TODO(toyoshim): Change following CHECKs to DCHECKs once we confirm these do
+ // not fire.
+ CHECK(isLoaded());
+ CHECK(!m_fontLoadShortLimitTimer.isActive());
+ CHECK(!m_fontLoadLongLimitTimer.isActive());
m_loadLimitState = LoadNotStarted;
Resource::setRevalidatingRequest(request);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698