[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993
Committed: https://crrev.com/73b62a1f1cf86534688657895c781abacfa615c4
Cr-Commit-Position: refs/heads/master@{#437828}

[kojii, 2016-12-05 07:20:12]

Description was changed from

==========
nginline

BUG=
==========

to

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

BUG=636993
==========

[kojii, 2016-12-05 07:28:36]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[kojii, 2016-12-05 07:28:37]

Far from landing but early feedback is appreciated.

* NGInlineLayoutAlgorithm needs a lot from NGBlockLayoutAlgorithm, correct? I
tried to subclass in this CL. Is this the right direction?
* How line boxes/root line boxes should be represented in fragment tree wasn't
clear, I made one assumption in this CL. Please have a look at comments in
NGTextLayoutAlgorithm::Layout().

I'm quite sure there are bunch of things I don't understand well yet, but hope
to figure out from your reviews.

[eae, 2016-12-05 13:54:58]

On 2016/12/05 07:28:37, kojii wrote:
> Far from landing but early feedback is appreciated.
> 
> * NGInlineLayoutAlgorithm needs a lot from NGBlockLayoutAlgorithm, correct? I
> tried to subclass in this CL. Is this the right direction?

Ideally we'd want to use composition instead of inheritance.

> * How line boxes/root line boxes should be represented in fragment tree wasn't
> clear, I made one assumption in this CL. Please have a look at comments in
> NGTextLayoutAlgorithm::Layout().

Still TBD but I think your approach here is good enough for now. We'll likely
have to revisit this as we implement support for more complex layout but as we
don't know exactly what we'll need yet it seems premature to try to think of all
eventualities.

> 
> I'm quite sure there are bunch of things I don't understand well yet, but hope
> to figure out from your reviews.

[ikilpatrick, 2016-12-06 17:22:51]

+1 on breaking the inheritance between NGInlineAlgorithm and NGBlockAlgorithm,
rough approach looks good!

[kojii, 2016-12-07 18:40:04]

PS2 stopped inheriting. Most logic were removed for now.

Is it ok to make the goal of this CL to:
* Make the call flows to go through NGTextLayoutAlgorithm and to CreateLine().
* Create fragment tree, though all data is empty.
and leave the rests to separate CLs? Anything you think should be included in
single CL, appreciate to know.

[kojii, 2016-12-07 18:44:57]

https://codereview.chromium.org/2551793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc (right):

https://codereview.chromium.org/2551793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc:219: // rest empty?
or maybe we should attach to line box or root line box, I'll think a bit more.

[eae, 2016-12-07 21:31:47]

This looks great. Ian, any objections?

[kojii, 2016-12-08 07:32:44]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 07:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-08 07:41:03]

Description was changed from

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

BUG=636993
==========

to

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

BUG=636993
==========

[kojii, 2016-12-08 08:09:01]

Description was changed from

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

BUG=636993
==========

to

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993
==========

[commit-bot: I haz the power, 2016-12-08 08:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 08:52:35]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-12-08 08:54:39]

PTAL. Cleaned up, fixed tests, updated description.

[ikilpatrick, 2016-12-08 22:34:37]

lgtm , yeah lets sync about what we want the tree to look like.

also can you wait until: https://codereview.chromium.org/2519263002

has landed?

(may require a little reworking on your behalf).

[eae, 2016-12-09 01:25:10]

LGTM

[kojii, 2016-12-09 02:46:51]

On 2016/12/08 at 22:34:37, ikilpatrick wrote:
> also can you wait until: https://codereview.chromium.org/2519263002
> has landed?
> (may require a little reworking on your behalf).

Will do, thank you.

[kojii, 2016-12-12 03:47:06]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 03:47:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 03:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 03:58:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-12-12 05:12:57]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 05:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 06:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 06:59:49]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-12-12 07:00:09]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-12-12 07:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2551793002/#ps80001
(title: "Resolved merge conflicts")

[commit-bot: I haz the power, 2016-12-12 07:00:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 07:06:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481526009562240,
"parent_rev": "c11c9b4a2e2875ab77203841875060a6e3f571ed", "commit_rev":
"2bb90a2972f4aa22d0bee4bbfe47393ebf913a5c"}

[commit-bot: I haz the power, 2016-12-12 07:06:55]

Description was changed from

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993
==========

to

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993

Review-Url: https://codereview.chromium.org/2551793002
==========

[commit-bot: I haz the power, 2016-12-12 07:06:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-12 15:10:55]

Description was changed from

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993

Review-Url: https://codereview.chromium.org/2551793002
==========

to

==========
[LayoutNG] NGInlineLayoutAlgorithm and NGTextLayoutAlgorithm

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993

Committed: https://crrev.com/73b62a1f1cf86534688657895c781abacfa615c4
Cr-Commit-Position: refs/heads/master@{#437828}
==========

[commit-bot: I haz the power, 2016-12-12 15:10:56]

Patchset 5 (id:??) landed as
https://crrev.com/73b62a1f1cf86534688657895c781abacfa615c4
Cr-Commit-Position: refs/heads/master@{#437828}