Issue 2551773002: MacViews: Exploring removal of window-modal sheets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2551773002: MacViews: Exploring removal of window-modal sheets.

Created:
4 years ago by tapted

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, tfarina, extensions-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

MacViews: Exploring removal of window-modal sheets. Close.. but breaks dialog resize Checkpoint: support for window modals A fix but I no likee; Fix mac_views_browser compile after r435575 BUG= patch from issue 2547923005 at patchset 20001 (http://crrev.com/2547923005#ps20001)

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -69 lines)			Patch
M	chrome/browser/extensions/extension_view_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_view_host.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm	View	5 chunks	+10 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profiles/user_manager_mac.mm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.mm	View	3 chunks	+34 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc	View	5 chunks	+23 lines, -23 lines	0 comments	Download
M	components/constrained_window/constrained_window_views.cc	View	4 chunks	+8 lines, -20 lines	0 comments	Download
M	components/web_modal/modal_dialog_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/components/native_app_window/native_app_window_views.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/components/native_app_window/native_app_window_views.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_mac.mm	View	2 chunks	+6 lines, -2 lines	0 comments	Download