chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc - Issue 2551773002: MacViews: Exploring removal of window-modal sheets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

Issue 2551773002: MacViews: Exploring removal of window-modal sheets.

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.mm ('k') | chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

index 252af5175f38d9b2946f700c595c811abaee3c25..37fa17e3f1521557347317966ab09e56d998d74a 100644

--- a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

@@ -92,7 +92,14 @@ class ExtensionUninstallDialogDelegateView : public views::DialogDelegateView {

bool Cancel() override;

// views::WidgetDelegate:

- ui::ModalType GetModalType() const override { return ui::MODAL_TYPE_WINDOW; }

+ ui::ModalType GetModalType() const override {

+#if 0 && defined(OS_MACOSX)

+ // Use Tab-Modal on Mac (window-modal uses a "sheet").

+ return ui::MODAL_TYPE_CHILD;

+#else

+ return ui::MODAL_TYPE_WINDOW;

+#endif

+ }

base::string16 GetWindowTitle() const override;

// views::View: