gpu: Move native memory buffer configuration into //gpu

gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6a769424f689718b69b080117afed2907b7c1f9a
Cr-Commit-Position: refs/heads/master@{#437182}

[sadrul, 2016-12-04 02:35:46]

Description was changed from

==========
gpu: ...

BUG=643746
==========

to

==========
gpu: ...

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sadrul, 2016-12-04 02:35:48]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-04 02:35:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 04:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 04:26:24]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-07 03:58:43]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 03:59:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-07 04:00:24]

Description was changed from

==========
gpu: ...

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sadrul, 2016-12-07 04:03:31]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org, tsepez@chromium.org

[sadrul, 2016-12-07 04:03:32]

piman@ for all changes.

tsepez@ for gpu/ipc/common changes.

[commit-bot: I haz the power, 2016-12-07 04:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 04:42:16]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Tom Sepez, 2016-12-07 17:13:48]

lgtm

https://codereview.chromium.org/2551743002/diff/20001/gpu/ipc/common/gpu_memo...
File gpu/ipc/common/gpu_memory_buffer_support.cc (right):

https://codereview.chromium.org/2551743002/diff/20001/gpu/ipc/common/gpu_memo...
gpu/ipc/common/gpu_memory_buffer_support.cc:19: bool
IsNativeGpuMemoryBuffersEnabled() {
nit: Grammar authoritarians would say AreNativeGpuMemoryBuffersEnabled().

[sadrul, 2016-12-07 18:57:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-07 18:58:45]

Also updated mus to use this. PTAL.

https://codereview.chromium.org/2551743002/diff/20001/gpu/ipc/common/gpu_memo...
File gpu/ipc/common/gpu_memory_buffer_support.cc (right):

https://codereview.chromium.org/2551743002/diff/20001/gpu/ipc/common/gpu_memo...
gpu/ipc/common/gpu_memory_buffer_support.cc:19: bool
IsNativeGpuMemoryBuffersEnabled() {
On 2016/12/07 17:13:48, Tom Sepez wrote:
> nit: Grammar authoritarians would say AreNativeGpuMemoryBuffersEnabled().

Done.

[piman, 2016-12-07 19:41:44]

https://codereview.chromium.org/2551743002/diff/40001/gpu/ipc/common/gpu_memo...
File gpu/ipc/common/gpu_memory_buffer_support.cc (right):

https://codereview.chromium.org/2551743002/diff/40001/gpu/ipc/common/gpu_memo...
gpu/ipc/common/gpu_memory_buffer_support.cc:28:
switches::kDisableNativeGpuMemoryBuffers);
These switches are not forwarded to child processes (neither gpu process nor
renderer processes). I feel somewhat iffy about having functions in
gpu/ipc/common that only work in the browser process (and silently break in
other processes).

Maybe these should go into a new gpu/ipc/host directory, that would contain
logic that deals with the gpu process/service host, so that we can make it more
evident that these should only be called from the right places (enforced by DEPS
if needed).

BTW, how are these flags handled in mus?

[commit-bot: I haz the power, 2016-12-07 20:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:49:35]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-07 23:02:56]

https://codereview.chromium.org/2551743002/diff/40001/gpu/ipc/common/gpu_memo...
File gpu/ipc/common/gpu_memory_buffer_support.cc (right):

https://codereview.chromium.org/2551743002/diff/40001/gpu/ipc/common/gpu_memo...
gpu/ipc/common/gpu_memory_buffer_support.cc:28:
switches::kDisableNativeGpuMemoryBuffers);
On 2016/12/07 19:41:44, piman wrote:
> These switches are not forwarded to child processes (neither gpu process nor
> renderer processes). I feel somewhat iffy about having functions in
> gpu/ipc/common that only work in the browser process (and silently break in
> other processes).
> 
> Maybe these should go into a new gpu/ipc/host directory, that would contain
> logic that deals with the gpu process/service host, so that we can make it
more
> evident that these should only be called from the right places (enforced by
DEPS
> if needed).

I have made this change. '//gpu/ipc/host' target is not included in '//gpu',
which means the users of this code need to explicitly depend on this target.

> 
> BTW, how are these flags handled in mus? 

These flags are handled in MusGpuMemoryBufferManager (included in this CL),
which is used by the window server.

[sadrul, 2016-12-07 23:03:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 23:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-12-07 23:06:24]

thanks a bunch! LGTM

[commit-bot: I haz the power, 2016-12-07 23:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:08:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sadrul, 2016-12-07 23:25:57]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 23:26:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 00:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:09:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sadrul, 2016-12-08 00:11:27]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-12-08 00:11:27]

+sky@ for services/ui/common

[sadrul, 2016-12-08 01:13:26]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:03:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2016-12-08 04:03:55]

LGTM

[sadrul, 2016-12-08 04:18:04]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-12-08 04:18:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2551743002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-12-08 04:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[soniyaphilip04, 2016-12-08 04:26:29]

In JAVA API maximum-sized direct ByteBuffer for each thread it is look like a
native memory. The increment program work with the effective memory and
configuration process also wrap memory allocated. Get more information from best
thesis writing service   http://best-uk-dissertation.com/

[commit-bot: I haz the power, 2016-12-08 04:54:36]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481170684067000,
"parent_rev": "8ba3fb8867b13807ab2711286899a12a9ec8fcbb", "commit_rev":
"fae9e19fd0e78da3afd2dcba3c194dd2cabc0f2b"}

[commit-bot: I haz the power, 2016-12-08 04:55:04]

Description was changed from

==========
gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-08 04:55:05]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-08 04:56:50]

Description was changed from

==========
gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Move native memory buffer configuration into //gpu

This moves the code for getting the supported native memory buffer
configurations out of //content into //gpu. This allows this code
to be used by mus too.

BUG=643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6a769424f689718b69b080117afed2907b7c1f9a
Cr-Commit-Position: refs/heads/master@{#437182}
==========

[commit-bot: I haz the power, 2016-12-08 04:56:51]

Patchset 7 (id:??) landed as
https://crrev.com/6a769424f689718b69b080117afed2907b7c1f9a
Cr-Commit-Position: refs/heads/master@{#437182}