Change error messages for octal escape sequences

Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/089e4fd32c838f2ec6a001d8db7b8b227936b250
Cr-Commit-Position: refs/heads/master@{#41560}

[jwolfe, 2016-12-02 22:00:27]

Description was changed from

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jwolfe, 2016-12-02 22:00:27]

jwolfe@igalia.com changed reviewers:
+ littledan@chromium.org

[jwolfe, 2016-12-02 22:00:49]

PTAL

[Dan Ehrenberg, 2016-12-05 23:47:49]

lgtm

[jwolfe, 2016-12-05 23:49:59]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-12-05 23:50:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 23:50:52]

Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[Dan Ehrenberg, 2016-12-05 23:51:51]

Michael, did anything change with the way that the Blink trybot is supposed to
be invoked?

[Michael Achenbach, 2016-12-06 09:01:53]

Description was changed from

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Michael Achenbach, 2016-12-06 09:02:47]

On 2016/12/05 23:51:51, Dan Ehrenberg wrote:
> Michael, did anything change with the way that the Blink trybot is supposed to
> be invoked?

It seems to be called linux_trusty_blink_rel now. Changed your CL description.
Also our experimental trybot v8_linux_blink_rel ran and it had a bunch of
failures.

[jwolfe, 2016-12-07 00:02:56]

On 2016/12/06 09:02:47, Michael Achenbach wrote:
> It seems to be called linux_trusty_blink_rel now. Changed your CL description.
Thanks.

> Also our experimental trybot v8_linux_blink_rel ran and it had a bunch of
> failures.
I don't know what this means for me. I'm just going to try to commit this patch
again.

[jwolfe, 2016-12-07 00:03:03]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-12-07 00:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-12-07 00:16:28]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-07 00:18:35]

On 2016/12/07 00:02:56, jwolfe wrote:
> On 2016/12/06 09:02:47, Michael Achenbach wrote:
> > It seems to be called linux_trusty_blink_rel now. Changed your CL
description.
> Thanks.
> 
> > Also our experimental trybot v8_linux_blink_rel ran and it had a bunch of
> > failures.
> I don't know what this means for me. I'm just going to try to commit this
patch
> again.

Let's wait to commit this patch until we figure out how to get good tryjob
results. Michael seems to be saying that it leads to failures. Even if we didn't
have evidence of failures, and just understanding that it's risky (as we've
discussed), it's nice to avoid just landing something to save work for Michael
Achenbach or other sheriffs who would have to do the work of figuring out what
patch is it fault and rolling it back during the V8 roll into Blink.

[jwolfe, 2016-12-07 00:27:56]

On 2016/12/07 00:18:35, Dan Ehrenberg wrote:
> Michael seems to be saying that it leads to failures.
Oh. Sorry, I must have misunderstood. I thought he was saying the experimental
trybot was unreliable because it had a bunch of failures even without this
patch.

[Dan Ehrenberg, 2016-12-07 01:12:01]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 01:12:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:14:17]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-07 01:16:56]

On 2016/12/07 at 00:27:56, jwolfe wrote:
> On 2016/12/07 00:18:35, Dan Ehrenberg wrote:
> > Michael seems to be saying that it leads to failures.
> Oh. Sorry, I must have misunderstood. I thought he was saying the experimental
trybot was unreliable because it had a bunch of failures even without this
patch.

OK, looks like a more recent run of v8_linux_blink_rel did fine. I think this is
OK to land.

[jwolfe, 2016-12-07 16:32:01]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-12-07 16:32:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:26:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481128321566640, "parent_rev":
"96e145df0050a59dc4cb37a61f236997c457f5af", "commit_rev":
"bf07d905dc841c163574cca63b723506328bbe53"}

[commit-bot: I haz the power, 2016-12-07 17:26:30]

Description was changed from

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-12-07 17:26:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 17:26:47]

Description was changed from

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Change error messages for octal escape sequences

When an octal escape sequence is in a string in strict mode:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

When an octal escape sequence is in a template string:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/089e4fd32c838f2ec6a001d8db7b8b227936b250
Cr-Commit-Position: refs/heads/master@{#41560}
==========

[commit-bot: I haz the power, 2016-12-07 17:26:48]

Patchset 1 (id:??) landed as
https://crrev.com/089e4fd32c838f2ec6a001d8db7b8b227936b250
Cr-Commit-Position: refs/heads/master@{#41560}