Source/core/html/forms/CheckboxInputType.cpp - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/CheckboxInputType.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: "Fix compilation error on Windows and MAC" Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/CheckboxInputType.cpp

diff --git a/Source/core/html/forms/CheckboxInputType.cpp b/Source/core/html/forms/CheckboxInputType.cpp

index 738f9d58b9b0b15abb71a562058d9f40f5284f47..b751b08d24d62d11b2ffa16ae9d93f8d428b4f9b 100644

--- a/Source/core/html/forms/CheckboxInputType.cpp

+++ b/Source/core/html/forms/CheckboxInputType.cpp

@@ -107,4 +107,9 @@ bool CheckboxInputType::supportsIndeterminateAppearance() const

return true;

}

+bool CheckboxInputType::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)

+ return (oldValue != newValue) ? true: false;

keishi 2014/05/07 01:26:11 Couldn't this just be "oldValue != newValue"?

Habib Virji 2014/05/07 10:06:39 Done.

} // namespace WebCore

« Source/core/html/HTMLTextFormControlElement.cpp ('K') | « Source/core/html/forms/CheckboxInputType.h ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »