Chromium Code Reviews Chromium Code Reviews
Issue 255163002:
Dispatch change event for input type=checkbox when checked but value is null (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2010 Google Inc. All rights reserved. | 2 * Copyright (C) 2010 Google Inc. All rights reserved. |
| 3 * Copyright (C) 2011 Apple Inc. All rights reserved. | 3 * Copyright (C) 2011 Apple Inc. All rights reserved. |
| 4 * | 4 * |
| 5 * Redistribution and use in source and binary forms, with or without | 5 * Redistribution and use in source and binary forms, with or without |
| 6 * modification, are permitted provided that the following conditions are | 6 * modification, are permitted provided that the following conditions are |
| 7 * met: | 7 * met: |
| 8 * | 8 * |
| 9 * * Redistributions of source code must retain the above copyright | 9 * * Redistributions of source code must retain the above copyright |
| 10 * notice, this list of conditions and the following disclaimer. | 10 * notice, this list of conditions and the following disclaimer. |
| (...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 100 bool CheckboxInputType::isCheckbox() const | 100 bool CheckboxInputType::isCheckbox() const |
| 101 { | 101 { |
| 102 return true; | 102 return true; |
| 103 } | 103 } |
| 104 | 104 |
| 105 bool CheckboxInputType::supportsIndeterminateAppearance() const | 105 bool CheckboxInputType::supportsIndeterminateAppearance() const |
| 106 { | 106 { |
| 107 return true; | 107 return true; |
| 108 } | 108 } |
| 109 | 109 |
| 110 bool CheckboxInputType::shouldDispatchFormControlChangeEvent(String& oldValue, S tring& newValue) | |
| 111 { | |
| 112 return (oldValue != newValue) ? true: false; | |
|
keishi
2014/05/07 01:26:11
Couldn't this just be "oldValue != newValue"?
Habib Virji
2014/05/07 10:06:39
Done.
| |
| 113 } | |
| 114 | |
| 110 } // namespace WebCore | 115 } // namespace WebCore |
| OLD | NEW |
