Dispatch change event for input type=checkbox when checked but value is null

Source/core/html/HTMLTextFormControlElement.cpp

Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index c3f751a63f54d4eb643bdb97275b0ecbe1ae555c..459d766269248b3b0c7d171b331d0f3dd92a48b0 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -182,11 +182,18 @@ void HTMLTextFormControlElement::select()
     setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
 }
 
+bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)
+{
+    return false;
+}
+
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
-    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
+    String newValue = value();
+    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, newValue)

[tkent, 2014/05/07 01:24:57]

The equalIgnoringNullity check should be in
HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent and
InputType::shouldDispatchFormControlChangeEvent.

[keishi, 2014/05/07 01:26:11]

I think equalIgnoringNullity is part of the check required before dispatching
the change event. Is there any reason why this shouldn't be in
HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent?

[Habib Virji, 2014/05/07 10:06:39]

Done.

[Habib Virji, 2014/05/07 10:06:39]

Done.

+        || shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEvent, newValue)) {
         dispatchChangeEvent();
-        setTextAsOfLastFormControlChangeEvent(value());
+        setTextAsOfLastFormControlChangeEvent(newValue);
     }
     setChangedSinceLastFormControlChangeEvent(false);
 }