Dispatch change event for input type=checkbox when checked but value is null

Source/core/html/HTMLTextFormControlElement.cpp

Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index c3f751a63f54d4eb643bdb97275b0ecbe1ae555c..67e8c69cc1e9a1f07ca97b33c3128723b15c7003 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -182,9 +182,14 @@ void HTMLTextFormControlElement::select()
     setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
 }
 
+bool HTMLTextFormControlElement::isCheckbox() const
+{
+    return false;
+}
+
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
-    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
+    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value()) || (isCheckbox() && m_textAsOfLastFormControlChangeEvent != value())) {

[keishi, 2014/05/02 07:44:55]

HTMLTextFormControlElement exists to share code between the HTMLTextareaElement
and HTMLInputElement so I don't think it should know about input types.

I think we should make a virtual method for this line and do something like
this.
- Add HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(oldValue,
newValue)
- Override it in HTMLInputElement::shouldDispatchFormControlChangeEvent
- HTMLInputElement::shouldDispatchFormControlChangeEvent calls
InputType::shouldDispatchChangeEvent
- Override InputType::shouldDispatchChangeEvent in CheckboxInputType

[Habib Virji, 2014/05/02 15:07:40]

Done.

         dispatchChangeEvent();
         setTextAsOfLastFormControlChangeEvent(value());
     }