Dispatch change event for input type=checkbox when checked but value is null

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 164 matching lines @@
 void HTMLTextFormControlElement::setSelectionDirection(const String& direction)
 {
     setSelectionRange(selectionStart(), selectionEnd(), direction);
 }
 
 void HTMLTextFormControlElement::select()
 {
     setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
 }
 
+bool HTMLTextFormControlElement::isCheckbox() const
+{
+    return false;
+}
+
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
-    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
+    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value()) || (isCheckbox() && m_textAsOfLastFormControlChangeEvent != value())) {

[keishi, 2014/05/02 07:44:55]

HTMLTextFormControlElement exists to share code between the HTMLTextareaElement
and HTMLInputElement so I don't think it should know about input types.

I think we should make a virtual method for this line and do something like
this.
- Add HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(oldValue,
newValue)
- Override it in HTMLInputElement::shouldDispatchFormControlChangeEvent
- HTMLInputElement::shouldDispatchFormControlChangeEvent calls
InputType::shouldDispatchChangeEvent
- Override InputType::shouldDispatchChangeEvent in CheckboxInputType

[Habib Virji, 2014/05/02 15:07:40]

Done.

         dispatchChangeEvent();
         setTextAsOfLastFormControlChangeEvent(value());
     }
     setChangedSinceLastFormControlChangeEvent(false);
 }
 
 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* innerText)
 {
     ASSERT(renderer);
     return renderer->style()->visibility() != HIDDEN && innerText && innerText->renderer() && innerText->renderBox()->height();
@@ skipping 447 matching lines @@
 
     return "ltr";
 }
 
 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
 {
     return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));
 }
 
 } // namespace Webcore