Source/core/html/HTMLInputElement.h - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed input type check and instead using virtual function to check if input type is checkbox Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/checkbox-onchange-expected.txt ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | Source/core/html/HTMLTextFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index af27a9223b1e0e62a9bdabe864a5ea7cd5d732f3..9be065ac2a0e4c8435b309ebd31840a29c46b4e7 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -91,7 +91,7 @@ public:

bool isSearchField() const;

bool isInputTypeHidden() const;

bool isPasswordField() const;

- bool isCheckbox() const;

+ virtual bool isCheckbox() const OVERRIDE;

bool isRangeControl() const;

// FIXME: It's highly likely that any call site calling this function should instead