Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed input type check and instead using virtual function to check if input type is checkbox Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 // stepUp()/stepDown() for user-interaction. 84 // stepUp()/stepDown() for user-interaction.
85 bool isSteppable() const; 85 bool isSteppable() const;
86 86
87 bool isTextButton() const; 87 bool isTextButton() const;
88 88
89 bool isRadioButton() const; 89 bool isRadioButton() const;
90 bool isTextField() const; 90 bool isTextField() const;
91 bool isSearchField() const; 91 bool isSearchField() const;
92 bool isInputTypeHidden() const; 92 bool isInputTypeHidden() const;
93 bool isPasswordField() const; 93 bool isPasswordField() const;
94 bool isCheckbox() const; 94 virtual bool isCheckbox() const OVERRIDE;
95 bool isRangeControl() const; 95 bool isRangeControl() const;
96 96
97 // FIXME: It's highly likely that any call site calling this function should instead 97 // FIXME: It's highly likely that any call site calling this function should instead
98 // be using a different one. Many input elements behave like text fields, an d in addition 98 // be using a different one. Many input elements behave like text fields, an d in addition
99 // any unknown input type is treated as text. Consider, for example, isTextF ield or 99 // any unknown input type is treated as text. Consider, for example, isTextF ield or
100 // isTextField && !isPasswordField. 100 // isTextField && !isPasswordField.
101 bool isText() const; 101 bool isText() const;
102 102
103 bool isEmailField() const; 103 bool isEmailField() const;
104 bool isFileUpload() const; 104 bool isFileUpload() const;
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 RefPtr<InputTypeView> m_inputTypeView; 399 RefPtr<InputTypeView> m_inputTypeView;
400 // The ImageLoader must be owned by this element because the loader code ass umes 400 // The ImageLoader must be owned by this element because the loader code ass umes
401 // that it lives as long as its owning element lives. If we move the loader into 401 // that it lives as long as its owning element lives. If we move the loader into
402 // the ImageInput object we may delete the loader while this element lives o n. 402 // the ImageInput object we may delete the loader while this element lives o n.
403 OwnPtr<HTMLImageLoader> m_imageLoader; 403 OwnPtr<HTMLImageLoader> m_imageLoader;
404 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver; 404 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver;
405 }; 405 };
406 406
407 } //namespace 407 } //namespace
408 #endif 408 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698