Source/core/html/forms/BaseCheckableInputType.cpp - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseCheckableInputType.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/BaseCheckableInputType.cpp

diff --git a/Source/core/html/forms/BaseCheckableInputType.cpp b/Source/core/html/forms/BaseCheckableInputType.cpp

index 7ffe40b29da09b5859feb4eb739f8ef965be8d86..a8981830ca6d165072e42ba919bd66c5e8620b76 100644

--- a/Source/core/html/forms/BaseCheckableInputType.cpp

+++ b/Source/core/html/forms/BaseCheckableInputType.cpp

@@ -111,4 +111,9 @@ bool BaseCheckableInputType::isCheckable()

return true;

}

+bool BaseCheckableInputType::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)

+ return oldValue != newValue;

} // namespace WebCore

« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.h ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »