Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: Source/core/html/forms/BaseCheckableInputType.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.h ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 void BaseCheckableInputType::setValue(const String& sanitizedValue, bool, TextFi eldEventBehavior) 104 void BaseCheckableInputType::setValue(const String& sanitizedValue, bool, TextFi eldEventBehavior)
105 { 105 {
106 element().setAttribute(valueAttr, AtomicString(sanitizedValue)); 106 element().setAttribute(valueAttr, AtomicString(sanitizedValue));
107 } 107 }
108 108
109 bool BaseCheckableInputType::isCheckable() 109 bool BaseCheckableInputType::isCheckable()
110 { 110 {
111 return true; 111 return true;
112 } 112 }
113 113
114 bool BaseCheckableInputType::shouldDispatchFormControlChangeEvent(String& oldVal ue, String& newValue)
115 {
116 return oldValue != newValue;
117 }
118
114 } // namespace WebCore 119 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.h ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698