Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: Source/core/html/forms/InputType.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added tests for Radio to check onchange event trigger Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/forms/InputType.cpp
diff --git a/Source/core/html/forms/InputType.cpp b/Source/core/html/forms/InputType.cpp
index 7b714225fa912f078db351b7caa5d1885734b35f..bd09e3ef849a23b69a218ddc2285ac5083a4b432 100644
--- a/Source/core/html/forms/InputType.cpp
+++ b/Source/core/html/forms/InputType.cpp
@@ -547,6 +547,11 @@ bool InputType::storesValueSeparateFromAttribute()
return true;
}
+bool InputType::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)
+{
+ return !equalIgnoringNullity(oldValue, newValue);
+}
+
void InputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)
{
element().setValueInternal(sanitizedValue, eventBehavior);

Powered by Google App Engine
This is Rietveld 408576698