Source/core/html/forms/CheckboxInputType.h - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/CheckboxInputType.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests for Radio to check onchange event trigger Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLTextFormControlElement.h ('K') | « Source/core/html/HTMLTextFormControlElement.cpp ('k') | Source/core/html/forms/CheckboxInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/CheckboxInputType.h

diff --git a/Source/core/html/forms/CheckboxInputType.h b/Source/core/html/forms/CheckboxInputType.h

index e6d15d7f2fa4d1922877f460c1732c7eec380bb1..7c36d7d7ddc8bf6608cb6624435569873ed01a82 100644

--- a/Source/core/html/forms/CheckboxInputType.h

+++ b/Source/core/html/forms/CheckboxInputType.h

@@ -49,6 +49,7 @@ private:

virtual void didDispatchClick(Event*, const ClickHandlingState&) OVERRIDE;

virtual bool isCheckbox() const OVERRIDE;

virtual bool supportsIndeterminateAppearance() const OVERRIDE;

+ virtual bool shouldDispatchFormControlChangeEvent(String&, String&) OVERRIDE FINAL;

tkent 2014/05/07 10:09:56 This should be moved to BaseCheckableInputType, an

Habib Virji 2014/05/07 10:27:10 Done.

};

} // namespace WebCore