Source/core/html/forms/CheckboxInputType.h - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/forms/CheckboxInputType.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests for Radio to check onchange event trigger Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 private:	42 private:

43 CheckboxInputType(HTMLInputElement& element) : BaseCheckableInputType(elemen t) { }	43 CheckboxInputType(HTMLInputElement& element) : BaseCheckableInputType(elemen t) { }

44 virtual const AtomicString& formControlType() const OVERRIDE;	44 virtual const AtomicString& formControlType() const OVERRIDE;

45 virtual bool valueMissing(const String&) const OVERRIDE;	45 virtual bool valueMissing(const String&) const OVERRIDE;

46 virtual String valueMissingText() const OVERRIDE;	46 virtual String valueMissingText() const OVERRIDE;

47 virtual void handleKeyupEvent(KeyboardEvent*) OVERRIDE;	47 virtual void handleKeyupEvent(KeyboardEvent*) OVERRIDE;

48 virtual PassOwnPtr<ClickHandlingState> willDispatchClick() OVERRIDE;	48 virtual PassOwnPtr<ClickHandlingState> willDispatchClick() OVERRIDE;

49 virtual void didDispatchClick(Event*, const ClickHandlingState&) OVERRIDE;	49 virtual void didDispatchClick(Event*, const ClickHandlingState&) OVERRIDE;

50 virtual bool isCheckbox() const OVERRIDE;	50 virtual bool isCheckbox() const OVERRIDE;

51 virtual bool supportsIndeterminateAppearance() const OVERRIDE;	51 virtual bool supportsIndeterminateAppearance() const OVERRIDE;

	52 virtual bool shouldDispatchFormControlChangeEvent(String&, String&) OVERRIDE FINAL;
	tkent 2014/05/07 10:09:56 This should be moved to BaseCheckableInputType, an This should be moved to BaseCheckableInputType, and RadioInputType::shouldDispatchFormControlChangeEvent should be removed. Habib Virji 2014/05/07 10:27:10 Done. Show quoted text On 2014/05/07 10:09:56, tkent wrote: > This should be moved to BaseCheckableInputType, and > RadioInputType::shouldDispatchFormControlChangeEvent should be removed. Done.
52 };	53 };

53	54

54 } // namespace WebCore	55 } // namespace WebCore

55	56

56 #endif // CheckboxInputType_h	57 #endif // CheckboxInputType_h

OLD	NEW