Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2551603004:
Roll clang 287780:288545. (Closed)
|
Created:
4 years ago by Nico Modified:
4 years ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 287780:288545.
Ran `tools/clang/scripts/upload_revision.py 288545`.
This brings in a regression for linux lld (bug 670397), but nobody uses that yet.
In return, it speeds up CFI blacklist processing, makes it possible to turn on blink
PCH use on Windows (would crash previously), and makes win/asan work in
component builds again.
BUG=670392
TBR=hans
Committed: https://crrev.com/b5ed348a584d8ce2f46b5c28dee75643ca3357ab
Cr-Commit-Position: refs/heads/master@{#436228}
Patch Set 1 #
Messages
Total messages: 15 (10 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. BUG= ========== to ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 ==========
Description was changed from ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 ========== to ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
The msan failures are also happening with the old compiler, looks like a chromium-side problem: https://build.chromium.org/p/chromium.memory.full/console
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480904208611820, "parent_rev":
"32cff9d9d6f0d04a3b0d2343b67da248597f6b9a", "commit_rev":
"0687dced69a5350c20e6e285badb7bfd9f0ed24b"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans ========== to ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans ========== to ========== Roll clang 287780:288545. Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans Committed: https://crrev.com/b5ed348a584d8ce2f46b5c28dee75643ca3357ab Cr-Commit-Position: refs/heads/master@{#436228} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b5ed348a584d8ce2f46b5c28dee75643ca3357ab Cr-Commit-Position: refs/heads/master@{#436228}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
