Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2551593002: Rename fpdf_render_image and fpdf_render_text (Closed)

Created:
4 years ago by npm
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename fpdf_render_image and fpdf_render_text Committed: https://pdfium.googlesource.com/pdfium/+/4bed2af0c049bf499dcdb1327a47d40b4c0db92d

Patch Set 1 #

Patch Set 2 : Remove commented #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -529 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
A core/fpdfapi/render/cpdf_dibtransferfunc.h View 1 chunk +37 lines, -0 lines 0 comments Download
A + core/fpdfapi/render/cpdf_dibtransferfunc.cpp View 1 5 chunks +12 lines, -48 lines 0 comments Download
A + core/fpdfapi/render/cpdf_textrenderer.cpp View 3 chunks +9 lines, -33 lines 0 comments Download
M core/fpdfapi/render/cpdf_transferfunc.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/render/fpdf_render_image.cpp View 1 chunk +0 lines, -214 lines 0 comments Download
D core/fpdfapi/render/fpdf_render_text.cpp View 1 chunk +0 lines, -211 lines 0 comments Download
M core/fpdfapi/render/render_int.h View 2 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
npm
ptal
4 years ago (2016-12-02 20:51:37 UTC) #4
Tom Sepez
lgtm
4 years ago (2016-12-02 21:48:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551593002/20001
4 years ago (2016-12-02 21:49:11 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 22:01:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4bed2af0c049bf499dcdb1327a47d40b4c0d...

Powered by Google App Engine
This is Rietveld 408576698