Remove unused packaged app window controls code.

Remove unused packaged app window controls code.

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639
Committed: https://crrev.com/8d3c47d04559bbc8e95348ab7fae3cce1947af93
Cr-Commit-Position: refs/heads/master@{#439683}

[benwells, 2016-12-06 06:22:59]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 06:23:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 06:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 06:34:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2016-12-06 07:17:40]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 07:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 08:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 08:24:30]

Dry run: This issue passed the CQ dry run.

[benwells, 2016-12-06 09:22:11]

benwells@chromium.org changed reviewers:
+ tapted@chromium.org

[benwells, 2016-12-06 09:22:12]

+tapted for local review

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:275: //
TODO(kalman, fsamuel): Eagerly calling Require on context startup is
Oops, I should keep this comment (maybe remove kalman) as it still applies (and
I only deleted half of it).

[tapted, 2016-12-06 23:28:36]

https://codereview.chromium.org/2551303003/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2551303003/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:738: #if BUILDFLAG(ENABLE_EXTENSIONS)
Remove the #if/#endif?

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:273:
extensions::ModuleSystem* module_system = context->module_system();
nit: move into the `if` below, or just remove the temporary altogether

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:275: //
TODO(kalman, fsamuel): Eagerly calling Require on context startup is
On 2016/12/06 09:22:12, benwells wrote:
> Oops, I should keep this comment (maybe remove kalman) as it still applies
(and
> I only deleted half of it).

ack - might be good to move it inside the `if` too so that it's above the call
to `Require`

https://codereview.chromium.org/2551303003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/window_controls.js (left):

https://codereview.chromium.org/2551303003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/window_controls.js:11: var addTagWatcher =
require('tagWatcher').addTagWatcher;
It looks like this is the only (remaining) use of `tagWatcher` /
IDR_TAG_WATCHER_JS / extensions\tag_watcher.js -- can we remove that too?

[benwells, 2016-12-16 00:56:56]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 00:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-12-16 02:22:36]

I removed some extra stuff as well this time.

https://codereview.chromium.org/2551303003/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2551303003/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:738: #if BUILDFLAG(ENABLE_EXTENSIONS)
On 2016/12/06 23:28:36, tapted wrote:
> Remove the #if/#endif?

Done.

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:273:
extensions::ModuleSystem* module_system = context->module_system();
On 2016/12/06 23:28:36, tapted wrote:
> nit: move into the `if` below, or just remove the temporary altogether

Done.

https://codereview.chromium.org/2551303003/diff/20001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:275: //
TODO(kalman, fsamuel): Eagerly calling Require on context startup is
On 2016/12/06 23:28:36, tapted wrote:
> On 2016/12/06 09:22:12, benwells wrote:
> > Oops, I should keep this comment (maybe remove kalman) as it still applies
> (and
> > I only deleted half of it).
> 
> ack - might be good to move it inside the `if` too so that it's above the call
> to `Require`

Done.

https://codereview.chromium.org/2551303003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/window_controls.js (left):

https://codereview.chromium.org/2551303003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/window_controls.js:11: var addTagWatcher =
require('tagWatcher').addTagWatcher;
On 2016/12/06 23:28:36, tapted wrote:
> It looks like this is the only (remaining) use of `tagWatcher` /
> IDR_TAG_WATCHER_JS / extensions\tag_watcher.js -- can we remove that too?

Done.

[tapted, 2016-12-16 03:07:09]

lgtm

https://codereview.chromium.org/2551303003/diff/60001/chrome/renderer/extensi...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/2551303003/diff/60001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:276: //
Note: setting up the WebView class here, not the chrome.webview API.
optional nit: this comment could stay above the `if`, and the `Require` comment
be attached to the next line. That might be slightly clearer

[commit-bot: I haz the power, 2016-12-16 05:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:24:03]

Dry run: This issue passed the CQ dry run.

[benwells, 2016-12-19 03:54:12]

benwells@chromium.org changed reviewers:
+ bauerb@chromium.org

[benwells, 2016-12-19 03:54:13]

+bauerb for owners review of chrome/renderer/resources

https://codereview.chromium.org/2551303003/diff/60001/chrome/renderer/extensi...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/2551303003/diff/60001/chrome/renderer/extensi...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:276: //
Note: setting up the WebView class here, not the chrome.webview API.
On 2016/12/16 03:07:09, tapted wrote:
> optional nit: this comment could stay above the `if`, and the `Require`
comment
> be attached to the next line. That might be slightly clearer

Done.

[Bernhard Bauer, 2016-12-19 10:43:18]

c/r/resources LGTM

[benwells, 2016-12-20 00:23:04]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-12-20 00:23:04]

The CQ bit was unchecked by benwells@chromium.org

[benwells, 2016-12-20 00:23:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2551303003/#ps100001
(title: "Nit")

[commit-bot: I haz the power, 2016-12-20 00:23:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:59:14]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482193384855060,
"parent_rev": "0154101fe778da62c7134545338ec4dbdf8b9f26", "commit_rev":
"61141a4064f837974ba95c2b9d68a44e8264a50c"}

[commit-bot: I haz the power, 2016-12-20 02:59:44]

Description was changed from

==========
Remove unused packaged app window controls code.

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639
==========

to

==========
Remove unused packaged app window controls code.

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639

Review-Url: https://codereview.chromium.org/2551303003
==========

[commit-bot: I haz the power, 2016-12-20 02:59:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-20 03:02:59]

Description was changed from

==========
Remove unused packaged app window controls code.

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639

Review-Url: https://codereview.chromium.org/2551303003
==========

to

==========
Remove unused packaged app window controls code.

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639

Committed: https://crrev.com/8d3c47d04559bbc8e95348ab7fae3cce1947af93
Cr-Commit-Position: refs/heads/master@{#439683}
==========

[commit-bot: I haz the power, 2016-12-20 03:03:00]

Patchset 6 (id:??) landed as
https://crrev.com/8d3c47d04559bbc8e95348ab7fae3cce1947af93
Cr-Commit-Position: refs/heads/master@{#439683}