Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2551153002: Revert of Improve linearized pdf load/show time. (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Robert Sesek, Lei Zhang, tsepez, snake
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve linearized pdf load/show time. (patchset #5 id:80001 of https://codereview.chromium.org/2455403002/ ) Reason for revert: Breaks loading of linearized Dynamic XFA documents. e.g. The 'Dynamic Form Sample' on https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ breaks when loaded through the website. It loads correctly off of disk. Original issue's description: > Reland of Improve linearized pdf load/show time. > > Original issue's description: > > Improve linearized pdf load/show time. > > Reduce Pdf Plugin's count of reconnects. > > Add tests for PDFPlugin DocumentLoader. > > > > DocumentLoader was splitted into separate components, and missing tests was added for them. > > > > The main ideas in this CL are: > > > > 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position. > > 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind) > > 3) Isolate RangeRequest logic into DocumentLoader. Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing). > > 4) Fill this logic by tests. > > > > Example URL: > > http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf > > Comparison of changes: > > https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing > > > > Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9 > > Cr-Commit-Position: refs/heads/master@{#427752} > > Original review: > https://codereview.chromium.org/2349753003/ > > Committed: https://crrev.com/3704ccf02007dd912933abc3f3006159171bc41b > Cr-Commit-Position: refs/heads/master@{#429514} TBR=rsesek@chromium.org,thestig@chromium.org,art-snake@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -2952 lines) Patch
M pdf/BUILD.gn View 1 4 chunks +1 line, -11 lines 0 comments Download
M pdf/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M pdf/chunk_stream.h View 1 1 chunk +23 lines, -80 lines 0 comments Download
A pdf/chunk_stream.cc View 1 chunk +175 lines, -0 lines 0 comments Download
M pdf/chunk_stream_unittest.cc View 1 1 chunk +4 lines, -86 lines 0 comments Download
M pdf/document_loader.h View 1 3 chunks +62 lines, -48 lines 0 comments Download
M pdf/document_loader.cc View 1 4 chunks +397 lines, -253 lines 0 comments Download
D pdf/document_loader_unittest.cc View 1 chunk +0 lines, -1179 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M pdf/pdf_engine.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 4 chunks +6 lines, -11 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 14 chunks +70 lines, -95 lines 0 comments Download
M pdf/preview_mode_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M pdf/preview_mode_client.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
D pdf/range_set.h View 1 chunk +0 lines, -77 lines 0 comments Download
D pdf/range_set.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D pdf/range_set_unittest.cc View 1 chunk +0 lines, -303 lines 0 comments Download
D pdf/timer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D pdf/timer.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D pdf/url_loader_wrapper.h View 1 chunk +0 lines, -62 lines 0 comments Download
D pdf/url_loader_wrapper_impl.h View 1 chunk +0 lines, -89 lines 0 comments Download
D pdf/url_loader_wrapper_impl.cc View 1 chunk +0 lines, -325 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dsinclair
Created Revert of Improve linearized pdf load/show time.
4 years ago (2016-12-05 18:29:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551153002/1
4 years ago (2016-12-05 18:29:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/46888) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-05 18:34:15 UTC) #5
dsinclair
PTAL. The first patchset is the raw revert, the second patch set fixes up the ...
4 years ago (2016-12-05 19:55:55 UTC) #9
dsinclair
4 years ago (2016-12-06 17:00:43 UTC) #12
Message was sent while issue was closed.
On 2016/12/05 20:53:11, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Closing this. The Cl is intertwined with the redirect fix. Going to see if I can
figure out how to make dynamic XFA work with these changes.

Powered by Google App Engine
This is Rietveld 408576698