Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: chrome/android/java/res/layout/updating_gms_progress_view.xml

Issue 2551063003: Add a ProgressDialog during sign-in flow when GMS is updated. (Closed)
Patch Set: Update layout Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/updating_gms_progress_view.xml
diff --git a/chrome/android/java/res/layout/updating_gms_progress_view.xml b/chrome/android/java/res/layout/updating_gms_progress_view.xml
new file mode 100644
index 0000000000000000000000000000000000000000..d5b9235b07fb48d2ab9e6b56ad771ea8cfa96e3e
--- /dev/null
+++ b/chrome/android/java/res/layout/updating_gms_progress_view.xml
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<org.chromium.chrome.browser.widget.BoundedLinearLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
gogerald1 2016/12/15 21:58:53 may no need "xmlns:chrome="http://schemas.android.
estevenson 2016/12/15 22:13:22 It's still needed. I think to use BoundedLinearLay
+ android:gravity="center"
+ android:padding="24dp"
+ chrome:maxWidth="312dp"
+ style="@style/AlertDialogContent" >
+
+ <ProgressBar
+ android:id="@+id/progress"
+ android:layout_width="32dp"
+ android:layout_height="32dp"
+ android:layout_gravity="center_vertical" />
+
+ <TextView
+ android:id="@+id/message"
+ android:layout_width="wrap_content"
gogerald1 2016/12/15 21:58:53 can you re-order these attributes, like layout rel
estevenson 2016/12/15 22:13:22 Done.
+ android:layout_height="wrap_content"
+ android:lineSpacingMultiplier="1.4"
+ android:textSize="14sp"
+ android:layout_gravity="center_vertical"
+ android:layout_marginStart="24dp"
+ android:text="@string/signin_gms_updating" />
+</org.chromium.chrome.browser.widget.BoundedLinearLayout>

Powered by Google App Engine
This is Rietveld 408576698