chrome/android/java/res/layout/updating_gms_progress_view.xml - Issue 2551063003: Add a ProgressDialog during sign-in flow when GMS is updated.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/updating_gms_progress_view.xml

Issue 2551063003: Add a ProgressDialog during sign-in flow when GMS is updated. (Closed)

Patch Set: Update layout Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/account_signin_view.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.widget.BoundedLinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
	gogerald1 2016/12/15 21:58:53 may no need "xmlns:chrome="http://schemas.android. may no need "xmlns:chrome="http://schemas.android.com/apk/res-auto"" estevenson 2016/12/15 22:13:22 It's still needed. I think to use BoundedLinearLay Show quoted text On 2016/12/15 21:58:53, gogerald1 wrote: > may no need "xmlns:chrome="http://schemas.android.com/apk/res-auto"" It's still needed. I think to use BoundedLinearLayout?
	9 android:gravity="center"

	10 android:padding="24dp"

	11 chrome:maxWidth="312dp"

	12 style="@style/AlertDialogContent" >

	13

	14 <ProgressBar

	15 android:id="@+id/progress"

	16 android:layout_width="32dp"

	17 android:layout_height="32dp"

	18 android:layout_gravity="center_vertical" />

	19

	20 <TextView

	21 android:id="@+id/message"

	22 android:layout_width="wrap_content"
	gogerald1 2016/12/15 21:58:53 can you re-order these attributes, like layout rel can you re-order these attributes, like layout related first (width, height, gravity, margin, padding..), then view related (textsize, lineSpacing..., text) estevenson 2016/12/15 22:13:22 Done. Show quoted text On 2016/12/15 21:58:53, gogerald1 wrote: > can you re-order these attributes, like layout related first (width, height, > gravity, margin, padding..), then view related (textsize, lineSpacing..., text) Done.
	23 android:layout_height="wrap_content"

	24 android:lineSpacingMultiplier="1.4"

	25 android:textSize="14sp"

	26 android:layout_gravity="center_vertical"

	27 android:layout_marginStart="24dp"

	28 android:text="@string/signin_gms_updating" />

	29 </org.chromium.chrome.browser.widget.BoundedLinearLayout>

OLD	NEW