|
|
Chromium Code Reviews
DescriptionCleanup of blink::HTMLFieldSetElement
m_listedElements and related code are unnecessary now. |elements| HTML collection
is identical to m_listedElements. m_listedElements was necessary because
m_listedElements was a source of HTMLFormControlsCollection though vanilla
HTMLCollection doesn't need such source.
This CL has no behavior changes.
BUG=665291
Committed: https://crrev.com/932af91289f138471791a1dc30a2660ac719b55b
Cr-Commit-Position: refs/heads/master@{#436544}
Patch Set 1 #
Messages
Total messages: 35 (25 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Cleanup of blink::HTMLFieldSetElement m_associatedElements and related code are unnecessary now. We needed them because m_associatedElements was a source of HTMLFormControlsCollection. BUG= ========== to ========== Cleanup of blink::HTMLFieldSetElement m_associatedElements and related code are unnecessary now. We needed them because m_associatedElements was a source of HTMLFormControlsCollection. BUG=665291 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Cleanup of blink::HTMLFieldSetElement m_associatedElements and related code are unnecessary now. We needed them because m_associatedElements was a source of HTMLFormControlsCollection. BUG=665291 ========== to ========== Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. We needed them because m_listedElements was a source of HTMLFormControlsCollection. BUG=665291 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tkent@chromium.org changed reviewers: + kochi@chromium.org
kochi@, would you review this please? No hurry.
Is testing covered by the previous change https://codereview.chromium.org/2548453003/ ?
lgtm Discussed offline. Now the HTMLCollection returns what the listedElement() would return, so no behavior change and no test change needed.
Description was changed from ========== Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. We needed them because m_listedElements was a source of HTMLFormControlsCollection. BUG=665291 ========== to ========== Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. |elements| HTML collection is identical to m_listedElements. m_listedElements was necessary because m_listedElements was a source of HTMLFormControlsCollection though vanilla HTMLCollection doesn't need such source. This CL has no behavior changes. BUG=665291 ==========
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481009138513580,
"parent_rev": "1e98bea8733c80d69af9f2445e77ccbeb8cde421", "commit_rev":
"84f2294838499dcd2848b4292aaf5d09c8b027ab"}
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. |elements| HTML collection is identical to m_listedElements. m_listedElements was necessary because m_listedElements was a source of HTMLFormControlsCollection though vanilla HTMLCollection doesn't need such source. This CL has no behavior changes. BUG=665291 ========== to ========== Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. |elements| HTML collection is identical to m_listedElements. m_listedElements was necessary because m_listedElements was a source of HTMLFormControlsCollection though vanilla HTMLCollection doesn't need such source. This CL has no behavior changes. BUG=665291 Committed: https://crrev.com/932af91289f138471791a1dc30a2660ac719b55b Cr-Commit-Position: refs/heads/master@{#436544} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/932af91289f138471791a1dc30a2660ac719b55b Cr-Commit-Position: refs/heads/master@{#436544} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
