Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2550993002: Cleanup of blink::HTMLFieldSetElement (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of blink::HTMLFieldSetElement m_listedElements and related code are unnecessary now. |elements| HTML collection is identical to m_listedElements. m_listedElements was necessary because m_listedElements was a source of HTMLFormControlsCollection though vanilla HTMLCollection doesn't need such source. This CL has no behavior changes. BUG=665291 Committed: https://crrev.com/932af91289f138471791a1dc30a2660ac719b55b Cr-Commit-Position: refs/heads/master@{#436544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -51 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp View 3 chunks +6 lines, -42 lines 0 comments Download

Messages

Total messages: 35 (25 generated)
tkent
kochi@, would you review this please? No hurry.
4 years ago (2016-12-05 05:11:34 UTC) #18
kochi
Is testing covered by the previous change https://codereview.chromium.org/2548453003/ ?
4 years ago (2016-12-06 03:59:21 UTC) #19
kochi
lgtm Discussed offline. Now the HTMLCollection returns what the listedElement() would return, so no behavior ...
4 years ago (2016-12-06 04:02:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550993002/40001
4 years ago (2016-12-06 04:06:39 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/348402)
4 years ago (2016-12-06 05:56:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550993002/40001
4 years ago (2016-12-06 06:06:21 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/350424)
4 years ago (2016-12-06 06:50:06 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550993002/40001
4 years ago (2016-12-06 07:25:56 UTC) #31
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-06 08:32:30 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-06 08:34:46 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/932af91289f138471791a1dc30a2660ac719b55b
Cr-Commit-Position: refs/heads/master@{#436544}

Powered by Google App Engine
This is Rietveld 408576698