Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

Issue 2550993002: Cleanup of blink::HTMLFieldSetElement (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFieldSetElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp
index cc31336796d9bc2b4d0117d355e5bf1f7be7b83f..6cfd1bbf73af08255db41480daf398be6c793545 100644
--- a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp
@@ -28,9 +28,7 @@
#include "core/dom/ElementTraversal.h"
#include "core/dom/NodeListsNodeData.h"
#include "core/html/HTMLCollection.h"
-#include "core/html/HTMLFormControlsCollection.h"
#include "core/html/HTMLLegendElement.h"
-#include "core/html/HTMLObjectElement.h"
#include "core/layout/LayoutFieldset.h"
#include "wtf/StdLibExtras.h"
@@ -40,30 +38,23 @@ using namespace HTMLNames;
inline HTMLFieldSetElement::HTMLFieldSetElement(Document& document,
HTMLFormElement* form)
- : HTMLFormControlElement(fieldsetTag, document, form),
- m_documentVersion(0) {}
+ : HTMLFormControlElement(fieldsetTag, document, form) {}
HTMLFieldSetElement* HTMLFieldSetElement::create(Document& document,
HTMLFormElement* form) {
return new HTMLFieldSetElement(document, form);
}
-DEFINE_TRACE(HTMLFieldSetElement) {
- visitor->trace(m_listedElements);
- HTMLFormControlElement::trace(visitor);
-}
-
bool HTMLFieldSetElement::matchesValidityPseudoClasses() const {
return true;
}
bool HTMLFieldSetElement::isValidElement() {
- const ListedElement::List& elements = listedElements();
- for (unsigned i = 0; i < elements.size(); ++i) {
- if (elements[i]->isFormControlElement()) {
- HTMLFormControlElement* control =
- toHTMLFormControlElement(elements[i].get());
- if (!control->checkValidity(0, CheckValidityDispatchNoEvent))
+ HTMLCollection* elements = this->elements();
+ for (unsigned i = 0; i < elements->length(); ++i) {
+ if (elements->item(i)->isFormControlElement()) {
+ if (!toHTMLFormControlElement(elements->item(i))
+ ->checkValidity(nullptr, CheckValidityDispatchNoEvent))
return false;
}
}
@@ -115,33 +106,6 @@ HTMLCollection* HTMLFieldSetElement::elements() {
return ensureCachedCollection<HTMLCollection>(FormControls);
}
-void HTMLFieldSetElement::refreshElementsIfNeeded() const {
- uint64_t docVersion = document().domTreeVersion();
- if (m_documentVersion == docVersion)
- return;
-
- m_documentVersion = docVersion;
-
- m_listedElements.clear();
-
- for (HTMLElement& element : Traversal<HTMLElement>::descendantsOf(*this)) {
- if (isHTMLObjectElement(element)) {
- m_listedElements.append(toHTMLObjectElement(&element));
- continue;
- }
-
- if (!element.isFormControlElement())
- continue;
-
- m_listedElements.append(toHTMLFormControlElement(&element));
- }
-}
-
-const ListedElement::List& HTMLFieldSetElement::listedElements() const {
- refreshElementsIfNeeded();
- return m_listedElements;
-}
-
int HTMLFieldSetElement::tabIndex() const {
return HTMLElement::tabIndex();
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFieldSetElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698