nav timing 2 redirect allow opt-in

nav timing 2 redirect allow opt-in

BUG=665160
Committed: https://crrev.com/d3ac1c7a7ff4222e700720b5d93de532acd48b64
Cr-Commit-Position: refs/heads/master@{#438052}

[sunjian, 2016-12-03 01:47:43]

sunjian@chromium.org changed reviewers:
+ panicker@chromium.org

[panicker, 2016-12-05 19:11:53]

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:370: return;
Factor code above into a helper method getSecurityOrigin(..), to avoid DRY
issue: same lines repeated for ResourceTiming.

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:372: const
Vector<ResourceResponse>& redirectChain =
no need for temp variable?

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:374: bool
allowRedirectDetails = allowsTimingRedirect(redirectChain, finalResponse,
let's add a unittest for allowTimingRedirect(..)

[sunjian, 2016-12-06 01:24:27]

Patchset #2 (id:20001) has been deleted

[sunjian, 2016-12-06 01:48:47]

Patchset #2 (id:40001) has been deleted

[sunjian, 2016-12-06 19:46:44]

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:370: return;
On 2016/12/05 19:11:52, panicker wrote:
> Factor code above into a helper method getSecurityOrigin(..), to avoid DRY
> issue: same lines repeated for ResourceTiming.

Done.

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:372: const
Vector<ResourceResponse>& redirectChain =
On 2016/12/05 19:11:52, panicker wrote:
> no need for temp variable?

Done.

https://codereview.chromium.org/2550883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:374: bool
allowRedirectDetails = allowsTimingRedirect(redirectChain, finalResponse,
On 2016/12/05 19:11:52, panicker wrote:
> let's add a unittest for allowTimingRedirect(..)

Done.

[panicker, 2016-12-07 00:40:51]

panicker@chromium.org changed reviewers:
+ yoav@yoav.ws

[panicker, 2016-12-07 00:40:52]

LGTM

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:284: SecurityOrigin*
PerformanceBase::getSecurityOrigin() const {
Nit: prefer moving to anonymous namespace here as a helper and pass in
getExecutionContext() as an arg

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp (right):

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp:173:
NullExecutionContext nullExecutionContext;
Nit: Make this a member in PerformanceBaseTest?
In setUp you can: m_executionContext = new NullExecutionContext();
also avoid the const_casts.

[Yoav Weiss, 2016-12-07 03:03:05]

All in all, looks good. Can you please run the trybots on this?

[sunjian, 2016-12-07 20:07:19]

Patchset #3 (id:80001) has been deleted

[sunjian, 2016-12-07 20:09:02]

Patchset #3 (id:100001) has been deleted

[sunjian, 2016-12-07 20:10:32]

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:284: SecurityOrigin*
PerformanceBase::getSecurityOrigin() const {
On 2016/12/07 00:40:52, panicker wrote:
> Nit: prefer moving to anonymous namespace here as a helper and pass in
> getExecutionContext() as an arg

Done.

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp (right):

https://codereview.chromium.org/2550883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp:173:
NullExecutionContext nullExecutionContext;
On 2016/12/07 00:40:52, panicker wrote:
> Nit: Make this a member in PerformanceBaseTest?
> In setUp you can: m_executionContext = new NullExecutionContext();
> also avoid the const_casts.

Done.

[sunjian, 2016-12-07 20:10:36]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 20:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 21:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 21:47:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sunjian, 2016-12-07 21:56:41]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 21:57:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:39:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[panicker, 2016-12-08 17:21:26]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:50:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sunjian, 2016-12-08 22:50:31]

Patchset #3 (id:120001) has been deleted

[sunjian, 2016-12-08 22:50:52]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 22:51:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:12:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunjian, 2016-12-09 01:58:58]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 01:59:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 03:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:41:19]

Dry run: This issue passed the CQ dry run.

[panicker, 2016-12-09 20:22:57]

On 2016/12/07 03:03:05, Yoav Weiss wrote:
> All in all, looks good. Can you please run the trybots on this?

Friendly ping.
(the failing tests are unrelated)

[Yoav Weiss, 2016-12-11 05:47:57]

LGTM

[sunjian, 2016-12-12 23:21:33]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2016-12-12 23:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2550883003/#ps140001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-12-12 23:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2016-12-13 01:25:34]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2016-12-13 01:25:46]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2016-12-13 01:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2550883003/#ps160001
(title: "sync")

[commit-bot: I haz the power, 2016-12-13 01:27:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:12:03]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1481592346590040,
"parent_rev": "a6c34805d914be6629bab2d553be67133b60773c", "commit_rev":
"b7c98aa554e9e1e0c9b9a1ac70f77133ec4d5916"}

[commit-bot: I haz the power, 2016-12-13 04:13:32]

Description was changed from

==========
nav timing 2 redirect allow opt-in

BUG=665160
==========

to

==========
nav timing 2 redirect allow opt-in

BUG=665160

Review-Url: https://codereview.chromium.org/2550883003
==========

[commit-bot: I haz the power, 2016-12-13 04:13:33]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2016-12-13 04:18:08]

Description was changed from

==========
nav timing 2 redirect allow opt-in

BUG=665160

Review-Url: https://codereview.chromium.org/2550883003
==========

to

==========
nav timing 2 redirect allow opt-in

BUG=665160

Committed: https://crrev.com/d3ac1c7a7ff4222e700720b5d93de532acd48b64
Cr-Commit-Position: refs/heads/master@{#438052}
==========

[commit-bot: I haz the power, 2016-12-13 04:18:09]

Patchset 4 (id:??) landed as
https://crrev.com/d3ac1c7a7ff4222e700720b5d93de532acd48b64
Cr-Commit-Position: refs/heads/master@{#438052}