[stubs] Cleanup usages of CSA::Select().

[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.

BUG=

Committed: https://crrev.com/13cb1e54ab17bc7e2323aa15587e5084b550a00d
Cr-Commit-Position: refs/heads/master@{#41483}

[Igor Sheludko, 2016-12-02 23:49:05]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 23:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:17:41]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-05 08:33:28]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-12-05 08:40:19]

Description was changed from

==========
[stubs] Cleanup usages of CSA::Select().



BUG=
==========

to

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::SelectXXXConstant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

[Igor Sheludko, 2016-12-05 08:42:40]

Description was changed from

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::SelectXXXConstant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

to

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

[Igor Sheludko, 2016-12-05 08:45:55]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-12-05 08:47:39]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 08:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-05 08:48:48]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Igor Sheludko, 2016-12-05 08:48:49]

PTAL

https://codereview.chromium.org/2550683003/diff/40001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2550683003/diff/40001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:1196: a.WordNotEqual(match_indices,
a.NullConstant()));
Note: negated condition.

[Benedikt Meurer, 2016-12-05 09:00:18]

LGTM.

[commit-bot: I haz the power, 2016-12-05 09:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 09:32:29]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-05 11:29:53]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-12-05 11:30:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 11:31:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480937393725790,
"parent_rev": "323ccfb0e51d1099420115da50414287dce70790", "commit_rev":
"d43b640f027c0d8f24fe1d76caf9771b6cf1fa93"}

[commit-bot: I haz the power, 2016-12-05 11:31:41]

Description was changed from

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

to

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

[commit-bot: I haz the power, 2016-12-05 11:31:42]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-12-05 11:32:15]

Description was changed from

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.
   
BUG=
==========

to

==========
[stubs] Cleanup usages of CSA::Select().

1) CSA::Select() receives lambdas for generating true/false values.
   The representation parameter made mandatory.
2) CSA::Select[Type]Constant() methods receive true/false nodes directly.
   These methods are intended to be used for generating "selects" when
   true/false values are already computed.

BUG=

Committed: https://crrev.com/13cb1e54ab17bc7e2323aa15587e5084b550a00d
Cr-Commit-Position: refs/heads/master@{#41483}
==========

[commit-bot: I haz the power, 2016-12-05 11:32:16]

Patchset 1 (id:??) landed as
https://crrev.com/13cb1e54ab17bc7e2323aa15587e5084b550a00d
Cr-Commit-Position: refs/heads/master@{#41483}