Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2535753012: [stubs] Cleanup usages of lambdas in CodeStubAssembler and friends. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Cleanup usages of lambdas in CodeStubAssembler and friends. The changes are: 1) Pass lambdas as const references to avoid unnecessary copying. 2) Remove CodeStubAssembler* parameter from loop bodies and let the lambdas capture the right assembler instead. It makes the loop body code look uniform with the surrounding code and unblocks splitting of a CSA into different classes. BUG= Committed: https://crrev.com/3d618949e18fdfeb36f8918f061df3f533e923b8 Cr-Commit-Position: refs/heads/master@{#41482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -182 lines) Patch
M src/builtins/builtins-array.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 2 chunks +23 lines, -25 lines 0 comments Download
M src/code-stub-assembler.h View 5 chunks +21 lines, -21 lines 0 comments Download
M src/code-stub-assembler.cc View 17 chunks +69 lines, -80 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 4 chunks +33 lines, -36 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-02 19:36:58 UTC) #4
danno
lgtm
4 years ago (2016-12-05 10:56:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535753012/1
4 years ago (2016-12-05 11:00:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 11:28:54 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 11:29:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d618949e18fdfeb36f8918f061df3f533e923b8
Cr-Commit-Position: refs/heads/master@{#41482}

Powered by Google App Engine
This is Rietveld 408576698