Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2550673002: GN: Add Arm64 Linux support (Closed)

Created:
4 years ago by Riku Voipio
Modified:
4 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add Arm64 Linux support Add Arm64 linux support be able to build GN binary for native arm64 builds. R=dpranke@chromium.org, brettw@chromium.org Committed: https://crrev.com/b9a43ab09791a1dcfd185141f71627c3b8d437db Cr-Commit-Position: refs/heads/master@{#436256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/args.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Riku Voipio
Add Arm64 linux support be able to build GN binary for native arm64 builds.
4 years ago (2016-12-02 13:43:51 UTC) #1
Dirk Pranke
lgtm
4 years ago (2016-12-02 23:12:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550673002/1
4 years ago (2016-12-05 10:40:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:44:57 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9a43ab09791a1dcfd185141f71627c3b8d437db Cr-Commit-Position: refs/heads/master@{#436256}
4 years ago (2016-12-05 10:46:47 UTC) #12
brettw
4 years ago (2016-12-06 00:26:16 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698