Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255063004: Ignoring minimum size requirements for maximized windows, full screen windows and too small screens (Closed)

Created:
6 years, 7 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Ignoring minimum size requirements for maximized windows, full screen windows and too small screens BUG=366315 TEST=ash_unittest's and visual tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267416

Patch Set 1 #

Patch Set 2 : Fixed problem with panel layout manager #

Patch Set 3 : rebased #

Patch Set 4 : The panel layout manager was also required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -14 lines) Patch
M ash/wm/dock/docked_window_layout_manager.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/window_state.cc View 2 2 chunks +16 lines, -1 line 0 comments Download
M ash/wm/window_state_unittest.cc View 2 1 chunk +61 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 2 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Mr4D (OOO till 08-26)
Beng, this is mostly as you were asking for. On the long run we should ...
6 years, 7 months ago (2014-04-28 23:23:37 UTC) #1
Mr4D (OOO till 08-26)
Ooops - very sorry: Wrong email address. Ben, this is mostly as you were asking ...
6 years, 7 months ago (2014-04-28 23:47:11 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-04-29 05:10:45 UTC) #3
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 7 months ago (2014-04-29 14:08:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/255063004/1
6 years, 7 months ago (2014-04-29 14:08:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:52:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:52:59 UTC) #7
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 7 months ago (2014-04-29 19:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/255063004/1
6 years, 7 months ago (2014-04-29 19:03:20 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 23:30:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 23:30:24 UTC) #11
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 7 months ago (2014-04-30 02:53:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/255063004/1
6 years, 7 months ago (2014-04-30 02:55:43 UTC) #13
commit-bot: I haz the power
Change committed as 267084
6 years, 7 months ago (2014-04-30 05:20:48 UTC) #14
Michael Achenbach
A revert of this CL has been created in https://codereview.chromium.org/262593003/ by machenbach@chromium.org. The reason for ...
6 years, 7 months ago (2014-04-30 06:45:22 UTC) #15
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 7 months ago (2014-05-01 00:08:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/255063004/60001
6 years, 7 months ago (2014-05-01 00:09:32 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 04:12:44 UTC) #18
Message was sent while issue was closed. 
Change committed as 267416

Powered by Google App Engine
This is Rietveld 408576698