Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2550593004: Include -fsanitize=float-cast-overflow in is_ubsan=true builds. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
krasin1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include -fsanitize=float-cast-overflow in is_ubsan=true builds. Also add a comment about the current state of ubsan. BUG=669642 Committed: https://crrev.com/2e147959b92ac70c0eb3e0568ae664d39614b68c Cr-Commit-Position: refs/heads/master@{#436093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/sanitizers/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
4 years ago (2016-12-02 22:39:59 UTC) #3
krasin1
LGTM
4 years ago (2016-12-02 22:42:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550593004/1
4 years ago (2016-12-02 22:43:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 00:19:43 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e147959b92ac70c0eb3e0568ae664d39614b68c Cr-Commit-Position: refs/heads/master@{#436093}
4 years ago (2016-12-03 00:23:23 UTC) #14
Nico
3 years, 12 months ago (2016-12-21 22:14:57 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2598813002/ by thakis@chromium.org.

The reason for reverting is: Somewhat speculative; it looks like clusterfuzz
might use this list and filed many many float overflow bugs
(https://bugs.chromium.org/p/chromium/issues/list?can=2&q=%22Float-cast-overfl...).
While we should fix all those, doing so by letting clusterfuzz file close to a
hundred bugs assigned to random people isn't the way we should go about it, and
CF filing all this bugs wasn't intended when I wrote this CL..

Powered by Google App Engine
This is Rietveld 408576698