Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3592)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2550593004: Include -fsanitize=float-cast-overflow in is_ubsan=true builds. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 36bceec225a2954814f4020c313a0dd0ae25b6fa..36d45c1d1b6f1edf77020d965aec0f298c3fa702 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -428,6 +428,9 @@ config("tsan_flags") {
}
}
+# UBSan is still in bring-up. Chrome builds with is_ubsan=true, but if you
+# set is_ubsan=true is_ubsan_no_recover = true, then many tests are still
+# failing.
config("ubsan_flags") {
cflags = []
if (is_ubsan) {
@@ -438,6 +441,7 @@ config("ubsan_flags") {
# enabled. See http://crbug.com/489901
# "-fsanitize=bounds",
"-fsanitize=float-divide-by-zero",
+ "-fsanitize=float-cast-overflow",
"-fsanitize=integer-divide-by-zero",
"-fsanitize=null",
"-fsanitize=object-size",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698