net/quic/core/quic_flags_list.h - Issue 2550453002: Fixed integer signing bug in cubic bytes/packet implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_flags_list.h

Issue 2550453002: Fixed integer signing bug in cubic bytes/packet implementation (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/core/quic_flags_list.h

diff --git a/net/quic/core/quic_flags_list.h b/net/quic/core/quic_flags_list.h

index 785f0b3290fd5b635792d4ff929da3c5494ccf73..d4ce695e1b66e69491a2fadc912bc938c1ca2bc2 100644

--- a/net/quic/core/quic_flags_list.h

+++ b/net/quic/core/quic_flags_list.h

@@ -160,3 +160,7 @@ QUIC_FLAG(bool, FLAGS_quic_fix_version_manager, false)

// Add a new client connection options field to QuicOptions which is only used

// to configure client side features, such as congestion control.

QUIC_FLAG(bool, FLAGS_quic_client_connection_options, true)

+// If true, fix some casts that were causing off-by-one errors in QUIC's cubic

+// "convex" increases.

+QUIC_FLAG(bool, FLAGS_quic_fix_cubic_convex_mode, true)

Zhongyi Shi 2016/12/01 22:15:23 Do we want to turn on this by default? We haven't

Zhongyi Shi 2016/12/01 22:47:51 Fine. Found it turned off in the flag flip cl.