net/quic/core/quic_flags_list.h - Issue 2550453002: Fixed integer signing bug in cubic bytes/packet implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/core/quic_flags_list.h

Issue 2550453002: Fixed integer signing bug in cubic bytes/packet implementation (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/quic/core/congestion_control/cubic.h ('K') | « net/quic/core/crypto/crypto_protocol.h ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file intentionally does not have header guards, it's included	5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate values.	6 // inside a macro to generate values.

7	7

8 // This file contains the list of QUIC protocol flags.	8 // This file contains the list of QUIC protocol flags.

9	9

10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC	10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC

(...skipping 142 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
153 // allow CHLO packets to be buffered until next iteration of the event loop.	153 // allow CHLO packets to be buffered until next iteration of the event loop.

154 QUIC_FLAG(bool, FLAGS_quic_allow_chlo_buffering, true)	154 QUIC_FLAG(bool, FLAGS_quic_allow_chlo_buffering, true)

155	155

156 // If true, fix version manager bug, in which version flag does not really	156 // If true, fix version manager bug, in which version flag does not really

157 // help.	157 // help.

158 QUIC_FLAG(bool, FLAGS_quic_fix_version_manager, false)	158 QUIC_FLAG(bool, FLAGS_quic_fix_version_manager, false)

159	159

160 // Add a new client connection options field to QuicOptions which is only used	160 // Add a new client connection options field to QuicOptions which is only used

161 // to configure client side features, such as congestion control.	161 // to configure client side features, such as congestion control.

162 QUIC_FLAG(bool, FLAGS_quic_client_connection_options, true)	162 QUIC_FLAG(bool, FLAGS_quic_client_connection_options, true)

	163

	164 // If true, fix some casts that were causing off-by-one errors in QUIC's cubic

	165 // "convex" increases.

	166 QUIC_FLAG(bool, FLAGS_quic_fix_cubic_convex_mode, true)
	Zhongyi Shi 2016/12/01 22:15:23 Do we want to turn on this by default? We haven't Do we want to turn on this by default? We haven't turn on this internally. Zhongyi Shi 2016/12/01 22:47:51 Fine. Found it turned off in the flag flip cl. Show quoted text On 2016/12/01 22:15:23, Zhongyi Shi wrote: > Do we want to turn on this by default? We haven't turn on this internally. Fine. Found it turned off in the flag flip cl.
OLD	NEW