Add conditional package name expansion.

Add SIMPLE conditional package name expansion.

This will allow ensure files to have lines like:

  infra/tools/git/${platform=windows}-${arch}  git_revision:deadbeef....

To support cipd-ification of e.g. depot_tools without wrapper scripts.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
Review-Url: https://codereview.chromium.org/2550413008
Committed: https://github.com/luci/luci-go/commit/3f4c0a36feb6ff528e1734eabc2b7033799fb26e

[iannucci, 2016-12-09 22:49:50]

Description was changed from

==========
Add conditional package name expansion.

This will allow ensure files to have lines like:

  infra/tools/git/${platform=windows}-${arch}  git_revision:deadbeef....

To support cipd-ification of e.g. depot_tools without wrapper scripts.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
==========

to

==========
Add SIMPLE conditional package name expansion.

This will allow ensure files to have lines like:

  infra/tools/git/${platform=windows}-${arch}  git_revision:deadbeef....

To support cipd-ification of e.g. depot_tools without wrapper scripts.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
==========

[iannucci, 2016-12-09 22:57:27]

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:1210: if err =
common.ValidateInstanceVersion(tokens[1]); err != nil {
This is just inlining the `err = check()` calls

[Vadim Sh., 2016-12-09 23:08:46]

lgtm with nit

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client_tes...
File cipd/client/cipd/client_test.go (right):

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client_tes...
cipd/client/cipd/client_test.go:610: Convey("ProcessEnsureFile template
package", t, func() {
add few more tests:

"${platform=mac}"
"something/${platform=mac}-${arch=386}"
"${platform=mac}${arch=386}"

[dnj, 2016-12-09 23:08:49]

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:1200: if pkg == "" {
Sentinel error?

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:1431: idx := strings.IndexRune(template, '$')
WDYT about regexp ReplaceAllFunc?

[iannucci, 2016-12-09 23:54:11]

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:1200: if pkg == "" {
On 2016/12/09 23:08:48, dnj wrote:
> Sentinel error?

Done

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:1431: idx := strings.IndexRune(template, '$')
On 2016/12/09 23:08:49, dnj wrote:
> WDYT about regexp ReplaceAllFunc?

Done.

[iannucci, 2016-12-10 00:06:40]

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client_tes...
File cipd/client/cipd/client_test.go (right):

https://codereview.chromium.org/2550413008/diff/1/cipd/client/cipd/client_tes...
cipd/client/cipd/client_test.go:610: Convey("ProcessEnsureFile template
package", t, func() {
On 2016/12/09 23:08:46, Vadim Sh. wrote:
> add few more tests:
> 
> "${platform=mac}"
> "something/${platform=mac}-${arch=386}"
> "${platform=mac}${arch=386}"

Done.

[iannucci, 2016-12-10 00:26:58]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-12-10 00:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2550413008/#ps40001
(title: "Add more tests")

[commit-bot: I haz the power, 2016-12-10 00:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 00:33:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481329618037850,
"parent_rev": "2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281", "commit_rev":
"3f4c0a36feb6ff528e1734eabc2b7033799fb26e"}

[commit-bot: I haz the power, 2016-12-10 00:33:15]

Description was changed from

==========
Add SIMPLE conditional package name expansion.

This will allow ensure files to have lines like:

  infra/tools/git/${platform=windows}-${arch}  git_revision:deadbeef....

To support cipd-ification of e.g. depot_tools without wrapper scripts.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
==========

to

==========
Add SIMPLE conditional package name expansion.

This will allow ensure files to have lines like:

  infra/tools/git/${platform=windows}-${arch}  git_revision:deadbeef....

To support cipd-ification of e.g. depot_tools without wrapper scripts.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843

Review-Url: https://codereview.chromium.org/2550413008
Committed:
https://github.com/luci/luci-go/commit/3f4c0a36feb6ff528e1734eabc2b7033799fb26e
==========

[commit-bot: I haz the power, 2016-12-10 00:33:16]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/3f4c0a36feb6ff528e1734eabc2b7033799fb26e