Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2550413007: Instant Apps: Add instrumentation tests. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Add instrumentation tests. Adds some of the missing tests for instant apps. Committed: https://crrev.com/916f90ce1912767f926d0389f988f49e8b1799c2 Cr-Commit-Position: refs/heads/master@{#439604}

Patch Set 1 #

Patch Set 2 : Add a missing file #

Total comments: 3

Patch Set 3 : Indent #

Patch Set 4 : Rebase #

Patch Set 5 : Fix test expectation. #

Messages

Total messages: 22 (12 generated)
Maria
4 years ago (2016-12-09 18:32:34 UTC) #2
Maria
On 2016/12/09 18:32:34, Maria wrote: ping
4 years ago (2016-12-16 23:36:44 UTC) #3
Ted C
lgtm https://codereview.chromium.org/2550413007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java (right): https://codereview.chromium.org/2550413007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java#newcode566 chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:566: .withPageTransition(transTypeLinkFromIntent) +4 indent here https://codereview.chromium.org/2550413007/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java#newcode581 chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:581: .withPageTransition(PageTransition.LINK) +4 ...
4 years ago (2016-12-19 15:56:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413007/40001
4 years ago (2016-12-19 17:06:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/10440) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-19 17:08:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413007/60001
4 years ago (2016-12-19 17:26:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/201786)
4 years ago (2016-12-19 18:51:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413007/80001
4 years ago (2016-12-19 22:27:40 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-19 23:08:39 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-19 23:10:52 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/916f90ce1912767f926d0389f988f49e8b1799c2
Cr-Commit-Position: refs/heads/master@{#439604}

Powered by Google App Engine
This is Rietveld 408576698