Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2550413005: ShapeDetection: use ImageBitmapSource as input and support ImageData (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
haraken, xianglu1
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShapeDetection: use ImageBitmapSource as input and support ImageData This CL : - s/CanvasImageSource/ImageBitmapSource/ in the idl following https://wicg.github.io/shape-detection-api/#face-detection-api and https://wicg.github.io/shape-detection-api/#barcode-detection-api CanvasImageSource [1] is almost a subset of ImageBitmapSource [2] (the former can be a CSSImageValue, but we don't care much about it for this Spec), so this CL is small in that sense. - Adds support for ImageData as a source for detect()ion, and adds a LayoutTest for it. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl?q=file:%5C.idl+CanvasImagesource&sq=package:chromium&l=33&dr=C [2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl?type=cs&q=file:%5C.idl+Imagebitmapsource&sq=package:chromium&l=38 BUG=670975 Committed: https://crrev.com/b935b59277c7f3cdc38d560fb6e305274f4e995c Cr-Commit-Position: refs/heads/master@{#438725}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : xianglu@ comments and added forgotten LayoutTest detection-ImageData.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html View 1 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 1 3 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (19 generated)
mcasas
xianglu@ PTAL
4 years ago (2016-12-14 22:06:17 UTC) #7
xianglu
https://codereview.chromium.org/2550413005/diff/40001/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right): https://codereview.chromium.org/2550413005/diff/40001/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp#newcode150 third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:150: ScriptPromise promise = resolver->promise(); Should we check origin for ...
4 years ago (2016-12-14 22:32:28 UTC) #8
mcasas
ptal also, notice that I uploaded detection-ImageData.html that I forgot before :P https://codereview.chromium.org/2550413005/diff/40001/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp ...
4 years ago (2016-12-14 23:37:42 UTC) #10
xianglu1
LGTM.
4 years ago (2016-12-15 00:26:39 UTC) #12
mcasas
haraken@ RS plz
4 years ago (2016-12-15 00:50:49 UTC) #16
haraken
LGTM
4 years ago (2016-12-15 00:53:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413005/60001
4 years ago (2016-12-15 01:14:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315181) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 01:20:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413005/60001
4 years ago (2016-12-15 01:28:55 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315197)
4 years ago (2016-12-15 01:34:25 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413005/60001
4 years ago (2016-12-15 02:38:54 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-15 03:41:12 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-15 03:44:20 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b935b59277c7f3cdc38d560fb6e305274f4e995c
Cr-Commit-Position: refs/heads/master@{#438725}

Powered by Google App Engine
This is Rietveld 408576698