Make ifdefs consistent in WebKit/Source/wtf/ .

Make ifdefs consistent in WebKit/Source/wtf/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
Committed: https://crrev.com/ac4ace1275f955ff70420065fa35e0ed565281b3
Cr-Commit-Position: refs/heads/master@{#437501}

[Alexander Alekseev, 2016-12-06 08:28:50]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 08:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-12-06 08:30:57]

alemate@chromium.org changed reviewers:
+ yutak@chromium.org

[Alexander Alekseev, 2016-12-06 08:30:57]

Please review.

[Yuta Kitamura, 2016-12-06 09:22:02]

https://codereview.chromium.org/2550403002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/StdLibExtras.h (right):

https://codereview.chromium.org/2550403002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/StdLibExtras.h:53: #if DCHECK_IS_ON()
We are already within DCHECK_IS_ON block. Why do you need another?

[Alexander Alekseev, 2016-12-06 09:51:02]

https://codereview.chromium.org/2550403002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/StdLibExtras.h (right):

https://codereview.chromium.org/2550403002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/StdLibExtras.h:53: #if DCHECK_IS_ON()
On 2016/12/06 09:22:02, Yuta Kitamura wrote:
> We are already within DCHECK_IS_ON block. Why do you need another?

Sorry, I first updated this block and then the outer one.

Fixed.

[Alexander Alekseev, 2016-12-06 09:51:42]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 09:51:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 13:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 13:03:37]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-12-09 07:42:28]

lgtm

[Alexander Alekseev, 2016-12-09 07:43:02]

Thank you!

[Alexander Alekseev, 2016-12-09 07:43:05]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-09 07:43:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 09:23:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20002, "attempt_start_ts": 1481269385971170,
"parent_rev": "f97cbb7c81ecd8f3c6c1538526a6f2ced85f3e45", "commit_rev":
"0e413d6114e71a7f697862f3dd10359a0288aa4f"}

[commit-bot: I haz the power, 2016-12-09 09:23:51]

Committed patchset #3 (id:20002)

[commit-bot: I haz the power, 2016-12-09 09:25:49]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/wtf/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
Make ifdefs consistent in WebKit/Source/wtf/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660

Committed: https://crrev.com/ac4ace1275f955ff70420065fa35e0ed565281b3
Cr-Commit-Position: refs/heads/master@{#437501}
==========

[commit-bot: I haz the power, 2016-12-09 09:25:50]

Patchset 3 (id:??) landed as
https://crrev.com/ac4ace1275f955ff70420065fa35e0ed565281b3
Cr-Commit-Position: refs/heads/master@{#437501}