Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: third_party/WebKit/Source/wtf/StdLibExtras.h

Issue 2550403002: Make ifdefs consistent in WebKit/Source/wtf/ . (Closed)
Patch Set: Fixed comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #ifndef WTF_StdLibExtras_h 26 #ifndef WTF_StdLibExtras_h
27 #define WTF_StdLibExtras_h 27 #define WTF_StdLibExtras_h
28 28
29 #include "base/numerics/safe_conversions.h" 29 #include "base/numerics/safe_conversions.h"
30 #include "wtf/Assertions.h" 30 #include "wtf/Assertions.h"
31 #include "wtf/CPU.h" 31 #include "wtf/CPU.h"
32 #include "wtf/LeakAnnotations.h" 32 #include "wtf/LeakAnnotations.h"
33 #include "wtf/TypeTraits.h" 33 #include "wtf/TypeTraits.h"
34 #include <cstddef> 34 #include <cstddef>
35 35
36 #if ENABLE(ASSERT) 36 #if DCHECK_IS_ON()
37 #include "wtf/Noncopyable.h" 37 #include "wtf/Noncopyable.h"
38 #include "wtf/Threading.h" 38 #include "wtf/Threading.h"
39 39
40 class WTF_EXPORT StaticLocalVerifier { 40 class WTF_EXPORT StaticLocalVerifier {
41 WTF_MAKE_NONCOPYABLE(StaticLocalVerifier); 41 WTF_MAKE_NONCOPYABLE(StaticLocalVerifier);
42 42
43 public: 43 public:
44 StaticLocalVerifier() 44 StaticLocalVerifier()
45 : m_safelyInitialized(WTF::isBeforeThreadCreated()), 45 : m_safelyInitialized(WTF::isBeforeThreadCreated()),
46 m_thread(WTF::currentThread()) {} 46 m_thread(WTF::currentThread()) {}
47 47
48 bool isNotRacy() { 48 bool isNotRacy() {
49 // Make sure that this 1) is safely initialized, 2) keeps being called 49 // Make sure that this 1) is safely initialized, 2) keeps being called
50 // on the same thread, or 3) is called within 50 // on the same thread, or 3) is called within
51 // AtomicallyInitializedStatic (i.e. with a lock held). 51 // AtomicallyInitializedStatic (i.e. with a lock held).
52 return m_safelyInitialized || m_thread == WTF::currentThread() || 52 return m_safelyInitialized || m_thread == WTF::currentThread()
53 WTF::isAtomicallyInitializedStaticMutexLockHeld(); 53 #if DCHECK_IS_ON()
Yuta Kitamura 2016/12/06 09:22:02 We are already within DCHECK_IS_ON block. Why do y
Alexander Alekseev 2016/12/06 09:51:02 Sorry, I first updated this block and then the out
54 || WTF::isAtomicallyInitializedStaticMutexLockHeld();
55 #else
56 /* Presubmit check prohibits bare ';'.*/
57 || false;
58 #endif
54 } 59 }
55 60
56 private: 61 private:
57 bool m_safelyInitialized; 62 bool m_safelyInitialized;
58 ThreadIdentifier m_thread; 63 ThreadIdentifier m_thread;
59 }; 64 };
60 #endif 65 #endif
61 66
62 namespace blink { 67 namespace blink {
63 template <typename T> 68 template <typename T>
(...skipping 19 matching lines...) Expand all
83 ASSERT(singleton); 88 ASSERT(singleton);
84 // If this assert triggers, you're supplying an empty ("()") 'Arguments' 89 // If this assert triggers, you're supplying an empty ("()") 'Arguments'
85 // argument to DEFINE_STATIC_LOCAL() - it must be the heap object you wish 90 // argument to DEFINE_STATIC_LOCAL() - it must be the heap object you wish
86 // to create as a static singleton and wrapped up with a Persistent 91 // to create as a static singleton and wrapped up with a Persistent
87 // reference. 92 // reference.
88 ASSERT(*singleton); 93 ASSERT(*singleton);
89 return **singleton; 94 return **singleton;
90 } 95 }
91 }; 96 };
92 97
93 #if ENABLE(ASSERT) 98 #if DCHECK_IS_ON()
94 #define DEFINE_STATIC_LOCAL_CHECK_THREADSAFE_ACCESS(Name) \ 99 #define DEFINE_STATIC_LOCAL_CHECK_THREADSAFE_ACCESS(Name) \
95 static StaticLocalVerifier Name##StaticLocalVerifier; \ 100 static StaticLocalVerifier Name##StaticLocalVerifier; \
96 ASSERT(Name##StaticLocalVerifier.isNotRacy()) 101 ASSERT(Name##StaticLocalVerifier.isNotRacy())
97 #else 102 #else
98 #define DEFINE_STATIC_LOCAL_CHECK_THREADSAFE_ACCESS(Name) 103 #define DEFINE_STATIC_LOCAL_CHECK_THREADSAFE_ACCESS(Name)
99 #endif 104 #endif
100 105
101 // Use DEFINE_STATIC_LOCAL() to declare and define a static local variable 106 // Use DEFINE_STATIC_LOCAL() to declare and define a static local variable
102 // (static T;) so that it is leaked and its destructors are not called at exit. 107 // (static T;) so that it is leaked and its destructors are not called at exit.
103 // T may also be a Blink garbage collected object, in which case it is 108 // T may also be a Blink garbage collected object, in which case it is
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 enum NotNullTag { NotNull }; 243 enum NotNullTag { NotNull };
239 inline void* operator new(size_t, NotNullTag, void* location) { 244 inline void* operator new(size_t, NotNullTag, void* location) {
240 ASSERT(location); 245 ASSERT(location);
241 return location; 246 return location;
242 } 247 }
243 248
244 using WTF::bitwiseCast; 249 using WTF::bitwiseCast;
245 using WTF::safeCast; 250 using WTF::safeCast;
246 251
247 #endif // WTF_StdLibExtras_h 252 #endif // WTF_StdLibExtras_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698