Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)
Patch Set: mac fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index a883c1466a25659f5b6bdf6f42fa4b3144f12ca5..5c574bea9418ebaf4c26e99c1df9c006627d29b1 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -80,8 +80,8 @@ TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersAfter) {
namespace {
class RepeatingTask : public blink::WebTaskRunner::Task {
public:
- RepeatingTask(blink::WebTaskRunner* web_task_runner, int* run_count)
- : web_task_runner_(web_task_runner), run_count_(run_count) {}
+ RepeatingTask(RefPtr<blink::WebTaskRunner> web_task_runner, int* run_count)
+ : web_task_runner_(std::move(web_task_runner)), run_count_(run_count) {}
~RepeatingTask() override {}
@@ -92,7 +92,7 @@ class RepeatingTask : public blink::WebTaskRunner::Task {
}
private:
- blink::WebTaskRunner* web_task_runner_; // NOT OWNED
+ RefPtr<blink::WebTaskRunner> web_task_runner_;
int* run_count_; // NOT OWNED
};
} // namespace
@@ -165,11 +165,11 @@ namespace {
class VirtualTimeRecorderTask : public blink::WebTaskRunner::Task {
public:
VirtualTimeRecorderTask(base::SimpleTestTickClock* clock,
- blink::WebTaskRunner* web_task_runner,
+ RefPtr<blink::WebTaskRunner> web_task_runner,
std::vector<base::TimeTicks>* out_real_times,
std::vector<size_t>* out_virtual_times_ms)
: clock_(clock),
- web_task_runner_(web_task_runner),
+ web_task_runner_(std::move(web_task_runner)),
out_real_times_(out_real_times),
out_virtual_times_ms_(out_virtual_times_ms) {}
@@ -183,7 +183,7 @@ class VirtualTimeRecorderTask : public blink::WebTaskRunner::Task {
private:
base::SimpleTestTickClock* clock_; // NOT OWNED
- blink::WebTaskRunner* web_task_runner_; // NOT OWNED
+ RefPtr<blink::WebTaskRunner> web_task_runner_;
std::vector<base::TimeTicks>* out_real_times_; // NOT OWNED
std::vector<size_t>* out_virtual_times_ms_; // NOT OWNED
};
@@ -310,10 +310,10 @@ class RunOrderTask : public blink::WebTaskRunner::Task {
class DelayedRunOrderTask : public blink::WebTaskRunner::Task {
public:
DelayedRunOrderTask(int index,
- blink::WebTaskRunner* task_runner,
+ RefPtr<blink::WebTaskRunner> task_runner,
std::vector<int>* out_run_order)
: index_(index),
- task_runner_(task_runner),
+ task_runner_(std::move(task_runner)),
out_run_order_(out_run_order) {}
~DelayedRunOrderTask() override {}
@@ -326,7 +326,7 @@ class DelayedRunOrderTask : public blink::WebTaskRunner::Task {
private:
int index_;
- blink::WebTaskRunner* task_runner_; // NOT OWNED
+ RefPtr<blink::WebTaskRunner> task_runner_;
std::vector<int>* out_run_order_; // NOT OWNED
};
}
@@ -483,7 +483,7 @@ TEST_F(WebViewSchedulerImplTest, DeleteThrottledQueue_InTask) {
DeleteWebFrameSchedulerTask* delete_frame_task =
new DeleteWebFrameSchedulerTask(web_view_scheduler_.get());
- blink::WebTaskRunner* timer_task_runner =
+ RefPtr<blink::WebTaskRunner> timer_task_runner =
delete_frame_task->web_frame_scheduler()->timerTaskRunner();
int run_count = 0;

Powered by Google App Engine
This is Rietveld 408576698