Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)
Patch Set: mac fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
index 1dc79fd6d6d80020d1ff43d6eb7032e40e53be56..2c97c02871e074ce5f9e4ee7ae90f441a580e47f 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
@@ -72,7 +72,7 @@ DEFINE_TRACE(ResourceLoader) {
}
void ResourceLoader::start(const ResourceRequest& request,
- WebTaskRunner* loadingTaskRunner,
+ RefPtr<WebTaskRunner> loadingTaskRunner,
bool defersLoading) {
DCHECK(!m_loader);
if (m_resource->options().synchronousPolicy == RequestSynchronously &&
@@ -84,7 +84,7 @@ void ResourceLoader::start(const ResourceRequest& request,
m_loader = wrapUnique(Platform::current()->createURLLoader());
DCHECK(m_loader);
m_loader->setDefersLoading(defersLoading);
- m_loader->setLoadingTaskRunner(loadingTaskRunner);
+ m_loader->setLoadingTaskRunner(loadingTaskRunner.get());
haraken 2016/12/08 01:49:02 Why do we need get()?
tzik 2016/12/12 12:18:52 eOn 2016/12/08 01:49:02, haraken wrote:
if (m_isCacheAwareLoadingActivated) {
// Override cache policy for cache-aware loading. If this request fails, a
@@ -103,11 +103,11 @@ void ResourceLoader::start(const ResourceRequest& request,
}
void ResourceLoader::restart(const ResourceRequest& request,
- WebTaskRunner* loadingTaskRunner,
+ RefPtr<WebTaskRunner> loadingTaskRunner,
bool defersLoading) {
CHECK_EQ(m_resource->options().synchronousPolicy, RequestAsynchronously);
m_loader.reset();
- start(request, loadingTaskRunner, defersLoading);
+ start(request, std::move(loadingTaskRunner), defersLoading);
}
void ResourceLoader::setDefersLoading(bool defers) {
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceLoader.h ('k') | third_party/WebKit/Source/core/frame/DOMTimer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698