Add LayoutTests for URL list of Response

Add LayoutTests for URL list of Response

https://codereview.chromium.org/2516353002/ introduces URL list of Response.

This URL list is an internal value which is not exposed to script.
To check the list in the LayoutTest, this CL introduces an internal API
getInternalResponseURLList().

BUG=658249
Committed: https://crrev.com/00af5e1dbf656a0b8f308583750d1e69c12b1148
Cr-Commit-Position: refs/heads/master@{#437533}

[horo, 2016-12-06 05:40:45]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 05:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 06:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 06:27:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-12-06 10:29:14]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 10:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 12:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 12:42:49]

Dry run: This issue passed the CQ dry run.

[horo, 2016-12-09 00:07:48]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2016-12-09 00:07:49]

falken@
Could you please review?

[falken, 2016-12-09 01:54:15]

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:391: 
Can you add documentation about the format of test_target?

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js:35:
self.internals.getInternalResponseURLList(response));
nit: actual and expected parameters are flipped (throughout this patch)

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:30:
assert_equals(size(urlList), 0,
I think size() is defined in fetch-test-helpers.js and only meant for headers.
Can this just be urlList.length?

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:31:
'The URL list of Default Response should not be empty.');
The description seems to contradict the assertion.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:109:
'The URL list of generated Response should not be empty.');
ditto with above

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html:63:
return fetch(TARGET_URL);
What's the purpose of this fetch?

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html:85:
service_worker_unregister_and_done(t, SCOPE);
nit: _and_done isn't needed for a promise_test. This can just be
service_worker_unregister or use add_compleition_callback to call
registration.unregister().

[horo, 2016-12-09 04:56:10]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 04:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-12-09 05:04:12]

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:391: 
On 2016/12/09 01:54:15, falken wrote:
> Can you add documentation about the format of test_target?

Done.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js:35:
self.internals.getInternalResponseURLList(response));
On 2016/12/09 01:54:15, falken wrote:
> nit: actual and expected parameters are flipped (throughout this patch)

Done.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:30:
assert_equals(size(urlList), 0,
On 2016/12/09 01:54:15, falken wrote:
> I think size() is defined in fetch-test-helpers.js and only meant for headers.
> Can this just be urlList.length?

Done.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:31:
'The URL list of Default Response should not be empty.');
On 2016/12/09 01:54:15, falken wrote:
> The description seems to contradict the assertion.

Done.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js:109:
'The URL list of generated Response should not be empty.');
On 2016/12/09 01:54:15, falken wrote:
> ditto with above

Done.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html
(right):

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html:63:
return fetch(TARGET_URL);
On 2016/12/09 01:54:15, falken wrote:
> What's the purpose of this fetch?

Removed.

https://codereview.chromium.org/2550363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html:85:
service_worker_unregister_and_done(t, SCOPE);
On 2016/12/09 01:54:15, falken wrote:
> nit: _and_done isn't needed for a promise_test. This can just be
> service_worker_unregister or use add_compleition_callback to call
> registration.unregister().

Done.

[falken, 2016-12-09 05:19:52]

lgtm

https://codereview.chromium.org/2550363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
(right):

https://codereview.chromium.org/2550363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:394:
// which will be called with the result of doFetch(). The thired element of
s/thired/third

https://codereview.chromium.org/2550363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:397:
// "eval(message.body)".
thanks. this is pretty tricky!

[horo, 2016-12-09 05:23:30]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 05:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-12-09 05:25:09]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2016-12-09 05:25:10]

mkwst@
Could you please review the following files?
- third_party/WebKit/Source/core/core_idl_files.gni
- third_party/WebKit/Source/modules/BUILD.gn
- third_party/WebKit/Source/modules/modules_idl_files.gni
- third_party/WebKit/Source/web/WebTestingSupport.cpp

[commit-bot: I haz the power, 2016-12-09 07:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 07:05:02]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-12-09 12:40:18]

LGTM.

[horo, 2016-12-09 14:26:44]

The CQ bit was checked by horo@chromium.org

[horo, 2016-12-09 14:26:45]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2550363002/#ps40001
(title: "s/thired/third/")

[commit-bot: I haz the power, 2016-12-09 14:26:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481293604780850,
"parent_rev": "d8bb6a2e090f11716943e914deebfd2bb7ad0d9a", "commit_rev":
"504946d3339a1cba4ca80348e02b0b74de840f6f"}

[commit-bot: I haz the power, 2016-12-09 14:37:47]

Description was changed from

==========
Add LayoutTests for URL list of Response

https://codereview.chromium.org/2516353002/ introduces URL list of Response.

This URL list is an internal value which is not exposed to script.
To check the list in the LayoutTest, this CL introduces an internal API
getInternalResponseURLList().

BUG=658249
==========

to

==========
Add LayoutTests for URL list of Response

https://codereview.chromium.org/2516353002/ introduces URL list of Response.

This URL list is an internal value which is not exposed to script.
To check the list in the LayoutTest, this CL introduces an internal API
getInternalResponseURLList().

BUG=658249

Review-Url: https://codereview.chromium.org/2550363002
==========

[commit-bot: I haz the power, 2016-12-09 14:37:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 14:39:35]

Description was changed from

==========
Add LayoutTests for URL list of Response

https://codereview.chromium.org/2516353002/ introduces URL list of Response.

This URL list is an internal value which is not exposed to script.
To check the list in the LayoutTest, this CL introduces an internal API
getInternalResponseURLList().

BUG=658249

Review-Url: https://codereview.chromium.org/2550363002
==========

to

==========
Add LayoutTests for URL list of Response

https://codereview.chromium.org/2516353002/ introduces URL list of Response.

This URL list is an internal value which is not exposed to script.
To check the list in the LayoutTest, this CL introduces an internal API
getInternalResponseURLList().

BUG=658249

Committed: https://crrev.com/00af5e1dbf656a0b8f308583750d1e69c12b1148
Cr-Commit-Position: refs/heads/master@{#437533}
==========

[commit-bot: I haz the power, 2016-12-09 14:39:37]

Patchset 3 (id:??) landed as
https://crrev.com/00af5e1dbf656a0b8f308583750d1e69c12b1148
Cr-Commit-Position: refs/heads/master@{#437533}