Move border-collapse to be generated in ComputedStyleBase

Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase. Also removed the explicit value
setters for EBorderCollapse and the one callsite where this was used
(implicit int conversion is not allowed for enum classes anyway).

BUG=628043
Committed: https://crrev.com/d6b2bca0a7e2347eebb2749d8723c10efb9b6778
Cr-Commit-Position: refs/heads/master@{#436523}

[napper, 2016-12-06 02:45:45]

The CQ bit was checked by napper@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 02:46:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[napper, 2016-12-06 03:06:35]

Description was changed from

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase.

BUG=628043
==========

[napper, 2016-12-06 03:06:35]

napper@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2016-12-06 03:08:04]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2016-12-06 03:08:04]

I'm surprised this doesn't fail the ASSERT_SIZE check that my patch was failing
:)

Sending to alancutter@ for initial review, I'll do follow-up.

[alancutter (OOO until 2018), 2016-12-06 03:50:30]

lgtm

https://codereview.chromium.org/2550343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2550343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:854: if
((borderCollapse() == EBorderCollapse::Collapse) &&
Pleased to see this change.

[sashab, 2016-12-06 03:52:15]

Please add to the CL description something like:

Also removed the explicit value setters for EBorderCollapse and the one callsite
where this was used (implicit int conversion is not allowed for enum classes
anyway).

Other than that LGTM! :D

[napper, 2016-12-06 04:04:44]

Description was changed from

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase. Also removed the explicit value
setters for EBorderCollapse and the one callsite where this was used
(implicit int conversion is not allowed for enum classes anyway).

BUG=628043
==========

[napper, 2016-12-06 04:05:06]

The CQ bit was unchecked by napper@chromium.org

[napper, 2016-12-06 04:05:10]

The CQ bit was checked by napper@chromium.org

[commit-bot: I haz the power, 2016-12-06 04:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 04:31:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480997110957300, "parent_rev":
"3b0dea446fc72da5e592dedf11e4061622a8865d", "commit_rev":
"a563ec16aaf40e7ae3748ca4db32af39386a5e9a"}

[commit-bot: I haz the power, 2016-12-06 04:34:44]

Description was changed from

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase. Also removed the explicit value
setters for EBorderCollapse and the one callsite where this was used
(implicit int conversion is not allowed for enum classes anyway).

BUG=628043
==========

to

==========
Move border-collapse to be generated in ComputedStyleBase

Move the inherited property caption-side and its enum, EBorderCollapse,
to be generated in ComputedStyleBase. Also removed the explicit value
setters for EBorderCollapse and the one callsite where this was used
(implicit int conversion is not allowed for enum classes anyway).

BUG=628043

Committed: https://crrev.com/d6b2bca0a7e2347eebb2749d8723c10efb9b6778
Cr-Commit-Position: refs/heads/master@{#436523}
==========

[commit-bot: I haz the power, 2016-12-06 04:34:45]

Patchset 1 (id:??) landed as
https://crrev.com/d6b2bca0a7e2347eebb2749d8723c10efb9b6778
Cr-Commit-Position: refs/heads/master@{#436523}